Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jan 2025 Updates: Load Year Fixes, ASHP Max Dispatch #473

Merged
merged 70 commits into from
Jan 21, 2025
Merged

Jan 2025 Updates: Load Year Fixes, ASHP Max Dispatch #473

merged 70 commits into from
Jan 21, 2025

Conversation

Bill-Becker
Copy link
Collaborator

@Bill-Becker Bill-Becker commented Jan 14, 2025 •
edited by zolanaj
Loading

zolanaj and others added 30 commits November 26, 2024 08:48
@zolanaj
add attribute force_dispatch to ASHP systems
e4858fc
@zolanaj
calculate reasonable max size if nothing provided or defaults used
0924e84
@zolanaj
include space heater forced dispatch
7c722da
@zolanaj
ren binASHPSHSizeExceedsHeatLoad binASHPSHSizeExceedsThermalLoad
1ee6978
@zolanaj
update max_ton calculation
4eb55d9
@zolanaj
add docstrings on max_ton calculation
8830517
@zolanaj
add cooling to forced dispatch
76a99a1
@zolanaj
add ASHPWaterHeater forced dispatch
5df8dfb
@zolanaj
introduce WH-specific DVs for big-M constraints
17f6e36
@zolanaj
fix binary constraints on ASHP Size >= load
4a3550c
@zolanaj
fix forced dispatch of ASHP with cooling
477ec4f
@zolanaj
revise segment max size calculation for ASHP
02310d9
@zolanaj
Add ASHP Forced Dispatch Tests
846145c
@zolanaj
Merge branch 'develop' into max-ashp-output
6427409
@Bill-Becker
Add test note about force_dispatch for cooling
8d8cf6e
@Bill-Becker
Fix handling of leap year for urdb rate tariff - truncate last day of…
db4228b 
… year instead of leap day
@Bill-Becker
Fix leap year timestep adjustments for demand charges
e82348b
@Bill-Becker
Update expected test LCC result value with a leap year analysis
4b58f6a
@Bill-Becker
Add tests for leap year energy and demand charge alignment with load …
418c422 
…profile
@Bill-Becker
Improve test description, avoid using Dates.jl in runtests.jl
7b116c7
@Bill-Becker
Improve test description, avoid using Dates.jl in runtests.jl
5511ac2
@Bill-Becker
Add leap year test input file
3a620f5
@Bill-Becker
Add leap year test input file
780dde3
@Bill-Becker
Fix input file path formatting
a381abe
@Bill-Becker
Fix input file path formatting
fdcdd6a
@Bill-Becker
Update changelog for leap year fix
b7f4590
@Bill-Becker
Include 2023 and 2024 years for all new tests
d6f7d4f
@Bill-Becker
Include 2023 and 2024 years for all new tests
fc9208b
@Bill-Becker
Merge pull request #470 from NREL/leap-year-fix
196e37d
@Bill-Becker
Update year input for HeatingLoad
dd13bed
Bill-Becker and others added 11 commits January 12, 2025 22:18
@Bill-Becker
Add more updates to Changelog.
e5a55e3
@Bill-Becker
Merge branch 'load-year-align' of https://github.com/NREL/REopt.jl in…
c91743c 
…to load-year-align
@Bill-Becker
Fix test input for doe_reference_name
cdcd928
@Bill-Becker
Update test with get_monthly_energy() now that it's consistent with l…
5f46a78 
…eap years
@adfarth
updating CoolingLoad help text
d62ef0e
@Bill-Becker
Update changelog for required year for heating and cooling load profi…
5d700be 
…le inputs too
@Bill-Becker
Make ElectricTariff.year = nothing by default, passed from ElectricLo…
74d362d 
…ad.year which is now required.
@Bill-Becker
Include industrial_reference_names for process heat default year of 2017
375289e
@Bill-Becker
Merge branch 'load-year-align' of https://github.com/NREL/REopt.jl in…
f67b06c 
…to load-year-align
@Bill-Becker
Merge pull request #472 from NREL/load-year-align
2e4b8e3 
Align heating and cooling load profiles with electric load year
@Bill-Becker
Merge branch 'master' into develop
9bdfe18
@Bill-Becker Bill-Becker mentioned this pull request Jan 14, 2025
Merged
zolanaj and others added 13 commits January 17, 2025 09:43
@zolanaj
Merge branch 'develop' into max-ashp-output
f57e86d
@zolanaj
suppress log to console in ASHP tests
04cdfaf
@zolanaj
allow nothing as input for max_ton so default is used
0a0983a
@zolanaj
adjust big M's for max system size to allow storage
cb86bb2
@zolanaj
reduce max system size for big-M management if very large number is p…
46363d9 
…rovided for ASHP max_ton
@zolanaj
Update CHANGELOG.md
d5983c4
@zolanaj
Merge pull request #462 from NREL/max-ashp-output
64f9732 
Maximize ASHP output in dispatch
@zolanaj
set ASHP default force_dispatch = true
d216c9d
@zolanaj
update force_dispatch in ASHP tests
90b4d58
@Bill-Becker
Update docs to reflect default force_dispatch=true
907d43a
@Bill-Becker
Change default min_allowable_peak_capacity_fraction to 0.25
1332d08 
Now that we default to force_dispatch=true, we can allow a lower min allowable size because we know it will dispatch a more significant amount of the heating and/or cooling load.
@Bill-Becker
Merge pull request #474 from NREL/ashp-force-dispatch-true
e2c8e3c 
Set ASHP forced dispatch to true by default
@Bill-Becker
Update CHANGELOG for pending v0.50.0
3dfbb76
@Bill-Becker Bill-Becker requested a review from zolanaj January 21, 2025 18:13
@Bill-Becker
Copy link
Collaborator Author

@zolanaj the leap year and load year alignment were both reviewed by Amanda, so I think this is good to go with your/my review on ASHP force_dispatch and default updates.

@Bill-Becker Bill-Becker changed the title Jan 2025 Updates: Load Year Alignments, ASHP Max Dispatch, Other Jan 2025 Updates: Load Year Fixes, ASHP Max Dispatch Jan 21, 2025
zolanaj
zolanaj approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@zolanaj zolanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bill-Becker! I added #474 to the conversation so that PR makes it into the release notes.

@Bill-Becker Bill-Becker merged commit 159ceb8 into master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zolanaj zolanaj zolanaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bill-Becker @zolanaj @adfarth