-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Grid Renewable Energy Fraction #426
Open
adfarth
wants to merge
107
commits into
develop
Choose a base branch
from
gridRE-dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
0d4a787
Add API call for renewable energy fraction
pypapus 71acc5e
Fixed cambium API call
pypapus eca3f12
Clean energy fraction added to scenarios
pypapus 80d1d3e
Include profile of grid clean energy contribution in kW
pypapus c095d48
Updated help text and added checks for user-provided values
pypapus b67ff48
Corrected off-grid flag in scenario.jl
pypapus 9a8f09f
Edited to remove cef calculation using BAU electric load
pypapus 379eeab
Added new "cef_constraints" to calculate clean energy fraction of the…
pypapus 26f5cec
Added cef (kWh) from the grid in accounting for renewable energy perc…
pypapus 4cce89e
Added new function to calculate the clean_energy_fraction (kWh) grid …
pypapus 6500b40
Added new input to include grid cef (kWh) in renewable energy percent…
pypapus 98d22b5
Updated function adds grid clean energy kWh serving the load to results
pypapus c3c4d90
Merge branch 'develop' into gridRE-dev
adfarth e3b0300
removed "hours_per_time_step" to use model time step.
pypapus 248481b
Added "annual_clean_grid_to_load_kwh" in results
pypapus 1d77ec8
Merge branch 'gridRE-dev' of https://github.com/NREL/REopt.jl into gr…
pypapus fbf7691
Combined cambium_emissions_profile() and cambium_clean_energy_fractio…
pypapus 29518dc
Update electric_utility.jl
adfarth 132f982
Merge branch 'develop' into gridRE-dev
adfarth 3a4bafd
spelling
adfarth 8a34550
Merge branch 'develop' into gridRE-dev
adfarth dec6733
change cambium_metric_col to cambium_co2_metric
adfarth 3916ba8
Change **cambium_emissions_region** to **cambium_region** and clean u…
adfarth 37de923
Update electric_utility.jl
adfarth ff29a78
emissions_profile to profile_data
adfarth cee8176
reorganize constraints
adfarth 8571808
minor edits
adfarth 60cdeae
simplify constraints
adfarth 7596768
Update renewable_energy_constraints.jl
adfarth 434f928
Update site.jl
adfarth 3b7a93a
update outputs
adfarth f2bb448
add outputs
adfarth a058fed
fix to align_profile_with_load_year
adfarth c2353fb
fixes to calcs
adfarth 42be276
Update financial.jl
adfarth b9b1509
Update runtests.jl
adfarth 82aaba4
add a test
adfarth 394ffc8
Update CHANGELOG.md
adfarth bf72ef7
avoid annual grid RE if mpc
adfarth b57f878
Update runtests.jl
adfarth f333311
address failing tests
adfarth f2b2871
Update runtests.jl
adfarth c357ddf
change variable name
adfarth a26e268
conditionally show warning
adfarth b8a93c2
add soc_init_fraction
adfarth f09fe6e
small updates
adfarth 9a4dd25
add a PV inputs check
adfarth 9491bb9
fix test
adfarth 5f6def7
fix to prod factor check
adfarth deeb15f
add description to outage_durations
adfarth b9aadb1
initial commit
adfarth c29810a
update help text
adfarth 239d8f2
update runtests
adfarth 4b27408
update cambium inputs and tests
adfarth 20f3cff
Update chp_payback.json
adfarth b228777
Update EMISSIONS_DECREASE_DEFAULTS
adfarth a0c0b77
change output names to stay below 63 chars
adfarth df4e6f0
Merge branch 'develop' into gridRE-dev
adfarth 9785939
Update CHANGELOG.md
hdunham 92d067b
update changelog/comment
hdunham 599e2e4
update notes about considerations when battery can export to grid in …
hdunham d1e9ff7
use REopt.KWH_PER_MMBTU in tests
hdunham 52b3c0f
minor comment updates
hdunham f022754
clarify test "Renewable Energy from Grid"
hdunham c4d7871
typo
hdunham 8ec5069
group renewable_energy_fraction_series with similar inputs in Electri…
hdunham 08b0ecb
add to error msg
hdunham 9c8b6a5
util function error_if_series_vals_not_0_to_1
hdunham bd1676e
Update runtests.jl
adfarth 818bedd
add to dictkeys_tosymbols
adfarth 74a3c4b
fix Degredation docstring
hdunham 156d035
Merge branch 'gridRE-dev' of https://github.com/NREL/REopt.jl into gr…
hdunham 5fc1160
fix make sub hr time step export rates work
hdunham e90f270
Update CHANGELOG.md
hdunham 360427b
update manifest
hdunham 55ef6fc
Merge branch 'develop' into gridRE-dev
adfarth c372337
Revert "Merge branch 'develop' into gridRE-dev"
adfarth be5695c
Merge branch 'develop' into avert-update
adfarth bdb9a45
Revert "update manifest"
adfarth 699abdd
use == to test string
hdunham 7bde370
Merge branch 'develop' into gridRE-dev
hdunham 8d6fcc6
resolve env with 1.8.3
hdunham 5610a11
update manifest to julia 1.11
hdunham a6bd8b5
simplify compat
hdunham f7a2d28
update authors
hdunham 37d32e1
typo
hdunham cc70963
Merge branch 'develop' into gridRE-dev
adfarth c51e442
Merge branch 'develop' into avert-update
adfarth b94a25e
Update CHANGELOG.md
adfarth 210ec72
rm inaccurate note in docstring
hdunham 77abfc0
fix typo
hdunham 6a922dc
clarify comment
hdunham 4836ea3
update comment
hdunham 5745957
Merge branch 'develop' into avert-update
adfarth e812def
Merge branch 'avert-update' of https://github.com/NREL/REopt.jl into …
adfarth c9c1aaa
Merge branch 'develop' into gridRE-dev
adfarth 3dcbc13
Merge branch 'avert-update' into gridRE-dev
adfarth 7b161a7
function name update
adfarth 3c0004b
Update CHANGELOG.md
adfarth a399b08
Merge branch 'develop' into gridRE-dev
adfarth 4b60d68
Update runtests.jl
adfarth 06e4366
remove TODO
adfarth 0653de3
fix merge issues, simplify results code
adfarth 0f3173f
Update Project.toml
adfarth 2ba6c06
Merge branch 'develop' into gridRE-dev
adfarth 3458e38
update julia version in workflows
adfarth a30e347
Update Manifest.toml
adfarth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the plan to merge #456 into this and then merge together or to merge one first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we would merge this one first if possible, because we might not get to that one until mid January. That PR would address an issue that already exists with all of the % RE calculations, whereas this one adds new RE outputs (that do also have the whole total load issue). Do you think that's an okay approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but another thought is that if there is a known issue that we aren't fixing right away I wonder if it makes sense to temporarily remove the affected total load related outputs and/or note it somewhere for users. Mid Jan is pretty soon though especially with the holidays so maybe not worth the time to do that.