Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow over a heliostat example #63

Merged
merged 21 commits into from
Oct 17, 2024
Merged

Flow over a heliostat example #63

merged 21 commits into from
Oct 17, 2024

Conversation

brookeslawski
Copy link
Collaborator

@brookeslawski brookeslawski commented Sep 11, 2024

This pull request adds an example of using PVade to simulate wind loading of a heliostat (used in concentrating solar power) rather than a PV panel. The example is documented in User Manual > Examples > Heliostat 3D.

To adapt PVade to modeling heliostats, I created a geometry module folder called heliostats3d, which is similar to panels3d, but has different specification of the fixation points on the back side of the heliostat. These fixation points better represent how a typical heliostat is mounted.

This functionality and associated documentation will aid general users in modeling loads on generalized solar collector designs.

@@ -156,7 +156,7 @@ properties:
panel_chord:
default: 2.0
minimum: 0.0
maximum: 10.0
maximum: 12.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow for heliostats, which are larger than PV panels

@eyoung55 eyoung55 added this to the FY24 Release milestone Oct 7, 2024
@eyoung55 eyoung55 self-assigned this Oct 7, 2024
Copy link
Collaborator

@arswalid arswalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytests are passing, and documentation builds. other changes add if condition for heliostat

Copy link
Collaborator

@eyoung55 eyoung55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! the domain setup and definitions, e.g., this is how we define chord", are awesome!

@eyoung55
Copy link
Collaborator

eyoung55 commented Oct 8, 2024

let's wait to merge until we get the code from kestrel (no rush to reproduce it locally) that rotates the measured point wrt the inflow wind direction.

@brookeslawski
Copy link
Collaborator Author

brookeslawski commented Oct 11, 2024

let's wait to merge until we get the code from kestrel (no rush to reproduce it locally) that rotates the measured point wrt the inflow wind direction.

Pulled in the code from kestrel. So once the checks complete, we should be all good.

@eyoung55 eyoung55 merged commit f622931 into NREL:dev Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants