-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to specify the inflow velocity profile type #60
base: dev
Are you sure you want to change the base?
Conversation
…(a float) over which vel goes from 0->u_ref
…ow a float that defines ramp up window
…olic+coeff+ramp_up_window for flag
Made some minor changes to pass the tests, but overall this looks great! I think this crosses some things off the to-do list, but test them and see what you think (and/or if more testing is necessary).
|
Does this address your final checkbox for "add ability to specify initial flow everywhere in domain (not just at x=0 plane)" |
Yes! That's exactly the functionality I was talking about. Thanks. |
merging
… with that in add_air_temperature
…ange to constant temperature
…n incorrect merging
…mperature bc merging
Planning to close this PR without merging as it has been superseded by PR #73 |
Addressing Issue #59
This PR removes the dependency of inflow type on the geometry module selected and instead allows the user to specify the desired inflow conditions at the inlet (x=0 plane).
Tasks: