Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to specify the inflow velocity profile type #60

Open
wants to merge 115 commits into
base: dev
Choose a base branch
from

Conversation

brookeslawski
Copy link
Collaborator

@brookeslawski brookeslawski commented Jun 11, 2024

Addressing Issue #59

This PR removes the dependency of inflow type on the geometry module selected and instead allows the user to specify the desired inflow conditions at the inlet (x=0 plane).

Tasks:

  • add inflow types
  • edit tests to include new inputs
  • update and test all existing examples: cyl2d, flag2d, cyl3d, panels3d
  • add ability to specify initial flow everywhere in domain (not just at x=0 plane)

@brookeslawski brookeslawski changed the base branch from main to dev June 11, 2024 22:11
@eyoung55
Copy link
Collaborator

eyoung55 commented Jun 13, 2024

Made some minor changes to pass the tests, but overall this looks great! I think this crosses some things off the to-do list, but test them and see what you think (and/or if more testing is necessary).
Changes:

  • specify loglaw and parabolic options for the test_flow_3dpanels and test_fsi2 tests
  • make time_varying_inflow_window a float as opposed to a bool, the value sets the ramp up time, 0 means no ramping, i.e., the initial velocity is just u_ref
  • moved some of the common pieces of code (e.g., prints, setting the value of time_vary_u_ref) outside the different cases for inflow profile type

@eyoung55
Copy link
Collaborator

Does this address your final checkbox for "add ability to specify initial flow everywhere in domain (not just at x=0 plane)"

@brookeslawski brookeslawski requested a review from eyoung55 June 18, 2024 16:01
@brookeslawski
Copy link
Collaborator Author

Does this address your final checkbox for "add ability to specify initial flow everywhere in domain (not just at x=0 plane)"

Yes! That's exactly the functionality I was talking about. Thanks.

@eyoung55 eyoung55 added this to the FY24 Release milestone Oct 7, 2024
brookeslawski and others added 27 commits November 18, 2024 12:09
@brookeslawski
Copy link
Collaborator Author

Planning to close this PR without merging as it has been superseded by PR #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants