Adding temperature to PVade via Rayleigh-Benard convective flow example #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…e loop and added zeroEntries
|
Regarding "This branch is out-of-date with the base branch" - I'm not sure why this is because I ran a |
merging origin/rayleigh_benard into local rayleigh_benard because they had diverged
brookeslawski
changed the title
brookeslawski
changed the title
3 tasks
|
Planning to close this PR without merging as it has been superseded by PR #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue #46
New changes applied while adding temperature:
upstream/syncgeom_dimwithndimto fix 2d/3d issues and added special treatment forndim==2versusnimd==3where necessary (which explains the changes to the structure files)