-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap ZoneHVAC:EvaporativeCoolerUnit #5326
Open
joseph-robertson
wants to merge
24
commits into
develop
Choose a base branch
from
zonehvac-evap-cooler
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
bc6477d
Add ZoneHVAC:EvaporativeCoolerUnit to idd.
joseph-robertson 26b5f56
Update the new idd entry.
joseph-robertson 5045e19
First add of model, ft, and test files.
joseph-robertson 40983fa
Update model resource files.
joseph-robertson 70dff3b
Update nodes in ft, general cleanup.
joseph-robertson 7fb2a46
Fix and improve model and ft tests.
joseph-robertson 9fc6562
Add tests and clean up cpp and ft.
joseph-robertson 1b3315e
Fix ft and tests.
joseph-robertson 985ffd7
Remove remove override and update tests.
joseph-robertson b9800aa
Add ZoneHVACEvaporativeCoolerUnit to all Fan's `containingZoneHVACCom…
jmarrec 3713357
Add ZoneHVACEvaporativeCoolerUnit to all evaporative cooler component…
jmarrec c6b3eeb
Improve and fixup tests
jmarrec d5d632a
Write Sensor Node Name (do we need to write relief air Node name?)
jmarrec d805651
Adjust node connections
jmarrec 86afadc
clang-format
jmarrec c969110
Implement autosizedDesignSupplyAirFlowRate correclty
jmarrec 66a2f6c
Always use the ZoneHVACEvaporativeCoolerUnit's outlet node as the Sen…
jmarrec 2477a80
Rewrite the FT and fix the issue where it was checking the type of th…
jmarrec 73365b1
Fix Severe Node Connection error
jmarrec d3e1fe9
Adjust FT test after node connections got fixed
jmarrec b9e6f0e
Add a TDB 3.9.1 release notes to mention the "Zone Relief Air Node Na…
jmarrec 65526d3
Change ctor to fansystemmodel, and update some tests.
joseph-robertson b510cdd
Fix ft test after ctor fan change.
joseph-robertson f8c27b8
Fix FT test.
joseph-robertson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a note in the TDB release notes