Code

Wrap ZoneHVAC:EvaporativeCoolerUnit#215

Code

Merged

jmarrec merged 11 commits intodevelopNREL/OpenStudio-resources:developfrom zonehvac-evap-coolerNREL/OpenStudio-resources:zonehvac-evap-coolerCopy head branch name to clipboardJan 30, 2025

+266-1

Commits

Commits on Jan 7, 2025

• Stub new zonehvac evap cooler test file.

  joseph-robertson

  committed
  be72603

  Copy full SHA for be72603

• Commit rubocop --auto-correct (Ruby ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux], Rubocop 0.81.0)

  

  github-rubocop-actions[bot]

  committed
  fa5ae45

  Copy full SHA for fa5ae45

Commits on Jan 16, 2025

• Adjust test and rename nodes for clarity

  jmarrec

  committed
  75f4ccc

  Copy full SHA for 75f4ccc

• Add missing TODO + exercice entire API for demonstration purposes

  jmarrec

  committed
  96801a1

  Copy full SHA for 96801a1

• Add ZoneHVACEvaporativeCoollerUnit to autosize_hvac

  jmarrec

  committed
  9eaada9

  Copy full SHA for 9eaada9

• Commit rubocop --auto-correct (Ruby ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux], Rubocop 0.81.0)

  

  github-rubocop-actions[bot]

  committed
  f16dda8

  Copy full SHA for f16dda8

• Make the test use both configuration: Direct first or Indirect first.

  jmarrec

  committed
  516030d

  Copy full SHA for 516030d

• The nodes are HARD to manage: test all combinations of Fan Placement x Direct/Indirect x secondary (8 combos)

  jmarrec

  committed
  9670dce

  Copy full SHA for 9670dce

• Commit rubocop --auto-correct (Ruby ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux], Rubocop 0.81.0)

  

  github-rubocop-actions[bot]

  committed
  f90ba33

  Copy full SHA for f90ba33

• Make a python version of the test

  jmarrec

  committed
  9c626d4

  Copy full SHA for 9c626d4

• Lint (isort & black) the new python test

  jmarrec

  committed
  0299faf

  Copy full SHA for 0299faf