Prepare for 3.8.0 release by running a 3-way comparison with 3.8.0-rc2 and adjusting tests #207
Conversation
23.2.0: District Heating was split in "District Heating Water" and "District Heating Steam"
…s not consistent) to produce constant results
…ansition 24.1.0 one
jmarrec
added
the
Other
| hx = coil_system.heatExchanger.to_HeatExchangerAirToAirSensibleAndLatent.get | ||
| hx.setName('CoilSystemWaterHX HX') | ||
| if Gem::Version.new(OpenStudio.openStudioVersion) >= Gem::Version.new('3.8.0') | ||
| hx.assignHistoricalEffectivenessCurves | ||
| end |
There was a problem hiding this comment.
Backward compat for HX AirToAir Sensible and Latent.
OS aligned the default on E+, which means constant efficiency (and no need for Table:Lookup objects). But to maintain historical EUI, need to use the convenience function to set the efficiency at 75% like it was pre 24.1.0
|
|
||
| windows = [] | ||
| spaces.each do |space| | ||
| surfaces = space.surfaces.sort_by { |s| s.name.to_s } | ||
| surfaces = space.surfaces.sort_by(&:azimuth) |
There was a problem hiding this comment.
The surfaces are not in a consistent naming convention, so instead we sort by azimuth, which ensures we always take for eg the East wall, and not randomly the West, North, South one
| if std.respond_to?('construction_calculated_solar_heat_gain_coefficient') | ||
| shgc = std.construction_calculated_solar_heat_gain_coefficient(construction_root) | ||
| else | ||
| # 0.6.0+ | ||
| shgc = OpenstudioStandards::Constructions.construction_get_solar_transmittance(surface_construction) | ||
| end |
There was a problem hiding this comment.
I started porting some of the code in openstudio_results to use newer methods and avoid sections breaking because NoMethodError or Optional not initialized, but there would be more to do to get it perfect.
@DavidGoldwasser as you already know, even if this specific measure inside this repo is very outdated, the most current on openstudio-common-measures-gem will also need some of the same treatment
| if standard.respond_to?('model_add_ground_temperatures') | ||
| standard.model_add_ground_temperatures(model, primary_bldg_type, climate_zone) | ||
| else | ||
| # 0.6.0+, model_set_ground_temperatures | ||
| OpenstudioStandards::Weather.model_set_ground_temperatures(model, climate_zone: climate_zone) | ||
| end |
There was a problem hiding this comment.
same stuff, that was causing an actual crash in model_articulation1 test. Because unlike openstudio_results, which just skips sections/table when something fails (a begin/rescue block is used), this crashes.
jmarrec
requested review from
joseph-robertson,
kbenne,
DavidGoldwasser and
wenyikuang
Pull request overview
No diffs due to OpenStudio, small differences (but lots of them) due to bumping E+. Max diff from bumping E+ is 0.8% so small indeed