-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional checks and suppress specific log warnings #761
Add conditional checks and suppress specific log warnings #761
Conversation
Conditionally check results only when all expected data is available to ensure complete validation. Suppress log warnings related to temporary directory removal to avoid unnecessary test failures.
@rh0dium These changes look fine to me. Did you need to make any changes for other tests (like the HERS Method test) or is this good to go? |
The other issue is that on |
Oh and one other tiny thing Could we do this on the last line of
This allows us to use RubyMine (which includes the SpecReporter) |
Yep, feel free to make those changes. |
Simplified and standardized the CSV generation to dynamically handle variable file inputs and their components. Adjusted indentation and added conditional logic to improve readability and maintainability throughout. Also ensured compatibility with specific environments in the minitest configuration.
Updated - Note: I did refactor a bit of the logic to make it clear in the headers which file relates to which output. I think this is probably preferred over the arbitrary "Test Results". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ran the tests locally and they all passed.
Pull Request Description
Conditionally check results only when all expected data is available to ensure complete validation. Suppress log warnings related to temporary directory removal to avoid unnecessary test failures.
Checklist
Not all may apply:
openstudio tasks.rb update_hpxmls
)rulesets\tests
and/orworkflow/tests/*_test.rb
)openstudio tasks.rb update_measures
has been run