Latest OS-HPXML #737
Merged
Latest OS-HPXML #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b61ad238c Merge pull request #1754 from NREL/stochastic_occupancy_paper 6ad895fd21 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into stochastic_occupancy_paper b4b0889fea Merge pull request #1748 from NREL/ruby-docs 8a67878d94 Merge branch 'ruby-docs' of github.com:NREL/OpenStudio-HPXML into ruby-docs 9a3cfe0e06 Progress on geometry resources and util for bills measure. 7415ef06e6 Prefer "@return [void]" per https://www.rubydoc.info/gems/yard/file/docs/Tags.md#literals ac607e6d8d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 07797db624 Merge branch 'ruby-docs' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 6938a956c2 More progress on hvac_sizing.rb code documentation. Some refactoring. 0c3b2be60a Latest results. 7c19270979 Merge pull request #1756 from NREL/ncflag_eq_zero 0828bfe93a Bugfix. 36668551f3 Use more places + a little cleanup. 9b58c2fab5 Removed hvac_sizing.rb method that is duplicative with a method in psychrometrics.rb. Small diffs expected. 63e7558b25 Adds error-checking for `NumberofConditionedFloorsAboveGrade`=0, which is not allowed per the documentation. 9eb6e23cc1 Forgot to save the file first. 22c28dd8b7 Update location.rb and simcontrols.rb. d17ec1d2af Small cleanup. 000f9a4e2b Some initial documentation for hvac_sizing.rb bb16756d71 Adds link to stochastic occupancy methodology paper to docs/READMEs. e5d8d793c9 Update TODOs in utility bills resource util.rb file. 1d98d6daf2 Merge branch 'master' into ruby-docs bb711e17cb Merge pull request #1752 from NREL/bob_ross_residence ded0af9076 Update Changelog.md [ci skip] 417b2e65f9 Latest results. f19d06dab7 Maintain previous geothermal loop sizing calculations (which are not based on MJ8). 654aaaab4f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into bob_ross_residence cefa57b5e8 Connect soil/moisture types to MJ8 ground conductivity values. Update example files. 3f178bb923 Fix CI? 55d90d45ad Add CI artifacts for ACCA examples. f8f28dfd4d soil type-heavy moist d5a3942250 Merge pull request #1751 from NREL/mj_blower_heat_and_piping 3a1e75d15f Ensure we calculate net capacity even when blower fan heat is provided. Update tests/docs. 58f6db9544 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into mj_blower_heat_and_piping d9b181111b Merge pull request #1750 from NREL/max_power_ratio_with_unit_multipliers 6db5ed8353 update hpxmls 573cc08d70 Merge branch 'bob_ross_residence' of https://github.com/NREL/OpenStudio-HPXML into bob_ross_residence 454f82aee6 skylight and slab changed to address some confusions 633e3b40f3 Latest results. f8bc39f8b1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into mj_blower_heat_and_piping 732f1d8687 Update workflow/tests/ACCA_Examples/Bob_Ross_Residence.xml bc66150963 Update workflow/tests/ACCA_Examples/Bob_Ross_Residence.xml 3dcb73dd2d Update workflow/tests/ACCA_Examples/Bob_Ross_Residence.xml 54ea03b290 Update workflow/tests/ACCA_Examples/Bob_Ross_Residence.xml 99438529a1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into max_power_ratio_with_unit_multipliers f61bbc7eb6 Merge pull request #1753 from NREL/fix_acca_duct_areas 13fd4efe69 Fix measure xml merge conflicts. 3394182262 Merge branch 'master' into ruby-docs 754ec95179 Fixes duct areas in ACCA test files. 0e2a0c487b update hpxmls b757924921 add ventilation 7d6a1e17a2 add bob ross residence test file 7cee8269bf A few more updates/fixes. 98c1891ffe Add blower fan heat and piping inputs for MJ design loads. fc2cae21fd Revert indent change [ci skip] 7e40c10468 Update changelog [ci skip] 20585aa29c Simplify PR template. 44c65e90d9 Bugfix. 2d33413cce Revert this. 3740f93ad7 Closes #103. 6446d6e365 Merge pull request #1745 from NREL/skylights-curbs-shafts 454d8fe35c Fix CI error. b587e8f729 Cleanup, more tests. 6f034115ec Progress filling in docs TODOs in measures. 2ec107e0dd Update changelog [ci skip] 443cd918a2 Merge branch 'skylights-curbs-shafts' of https://github.com/NREL/OpenStudio-HPXML into skylights-curbs-shafts 47c1e9af28 Add skylight curb/shaft tests. 523dc84aff Latest results. 53af7f26fb Merge branch 'skylights-curbs-shafts' of https://github.com/NREL/OpenStudio-HPXML into skylights-curbs-shafts 8350bd60b3 Initial implementation for skylight shafts. 58564f6980 Latest results. 0a35fe8026 Handle skylight curbs in energy model. Update sample HPXMLs. 93dd3cc3e3 Update the Walker example a bit more and some misc stuff. 2e6c82aa83 Latest results. 847b870d21 First pass on implementing skylight curbs/shafts. 76c953dde0 Merge pull request #1744 from NREL/attic-fnd-flexibility 357147f972 Another bugfix. 3d5f92c263 Bugfix. 8d2b1c6c2b Update Changelog.md [ci skip] c0ae834279 Minor docs update [ci skip] 91f0f1f390 Allows flexibility for multiple `Attic`/`Foundation` elements. 5007f27f62 Merge pull request #1683 from NREL/ruby-docs 5b93185665 Missed update to config. ada5915c57 Remove summary documentation test. 09ba7c587e Few params updates throughout. 1d69638296 Update and stub docs in measure.rb files. 89e595f45c Include measure.rb in checks. 08d0d5140f Move new step above Check HPXMLs. 19c03c703d Update measures d2e091924d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 1b182674a0 A little more. 30bfd3034f Merge pull request #1741 from NREL/garage-unexposed c4faa505d3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ruby-docs 3090af91e6 Pass on psychrometrics.rb. 7fb1913776 Merge pull request #1742 from NREL/Sashadf1-patch-1 72c4aca93d Update comments in hvac.rb c1d1066057 oops 3a568c9cc9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into garage-unexposed 0e6131cfce Merge branch 'garage-unexposed' of https://github.com/NREL/OpenStudio-HPXML into garage-unexposed 8a10ea2927 combine is_exposed 33051b2cbc Merge branch 'master' into ruby-docs 5ca20332d1 Merge pull request #1740 from NREL/furnace_heating_airflow_bugfix 7db0f3d104 Latest results. 3a6f553fb5 Latest results. 45023644f2 change garage to be unexposed 15deded760 Increase tolerance c55bcfb62d Test run. 5beb1b99f1 Update measure xml. e0d47de254 Merge branch 'master' into ruby-docs 22ce54c20b Update measure xml. 517b644b4d Merge branch 'master' into ruby-docs 3588fe3c4d Merge branch 'master' into ruby-docs 167e5ecfbb Measure xml update. e7f7c13b55 Merge branch 'master' into ruby-docs 0d6aa1ac2a More cleanup. c821a7d79f Merge branch 'master' into ruby-docs 8336761bcc Merge branch 'master' into ruby-docs 2a5a6dbe26 Remove remaining todo in hpxml.rb. af359d6e80 Fix some required args. da7070e47f More cleanup. 36fb66da12 Few more excludes, and some cleanup. 01af03b969 Update gitignore, rubocop yml, remove script. ee67cc3876 Progress. 57ea82ea6e More refactoring. ea1b960d89 More progress. 23a4c27fc5 Updates for common arguments. 01beebae43 Fix return stub. cfc27f25da Remove whitespace. 6c4fc6393f Add description placeholder above class. 4e9a8c3890 Actually copy the files in. 30ebb11781 Fix docs with multiple description lines. 1f866c59fc Merge branch 'master' into ruby-docs 47a2732ae1 Add resources with first cut docs placeholders. 5b618f0a4a First cut at a script for stubbing resource docs. 54bcd49eda Merge branch 'master' into ruby-docs ffa345e6e7 Progress. ca5fc2e33c Another kw arg update. d2746babe0 Geometry kw arg updates. 7082e3d900 Forgot to put the class method selfs back in. 428c364f55 Update to kw args in translator geometry resource. 409f378885 Fix some confusion and inconsistencies around private statements, continue to add docs. 59a16c279e Merge branch 'master' into ruby-docs 464e8dfa9b Start adding docs to geometry resources. 7230e72f33 Update build measure resources with kw args. 53f13d5bd7 Fix more bad formatting. 95cb226904 Revert a bunch of unintended formatting. a604e2fbd5 Merge branch 'master' into ruby-docs b61a3ea06d Revert changes to config, gemfile, rakefile. 221bd01988 Stub documentation comments for all build measure methods. 2b1dde1af0 Exclude test files from documentation requirement using rubocop yml file. f62b2bacd5 Another try capturing stderr. 4479bc6766 Check if block. ae0726c785 Try exit code when update_measures contains string. cb4baf4926 Add documentation cops and try update_measures on gha. bdb19a3a4a Merge branch 'master' into ruby-docs 57fbac4780 Try yard rake task and cli. 77f234f411 Merge branch 'master' into ruby-docs f201a748ee Report more coverage information. 057691aab6 Merge branch 'master' into ruby-docs c30615d2bf Merge branch 'master' into ruby-docs cd55832c35 Add rake task and update config. bd3a56cbd4 Add workflow test file for checking doc percent. git-subtree-dir: hpxml-measures git-subtree-split: 5b61ad238c35c38ad813f01d8ccfb921ae4d0d26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
New Features
Bugfixes
NumberofConditionedFloorsAboveGrade=0, which is not allowed per the documentation.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
openstudio tasks.rb update_hpxmls)rulesets\testsand/orworkflow/tests/*_test.rb)openstudio tasks.rb update_measureshas been run