Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative ceiling fan watts input #720

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Feb 27, 2024

Pull Request Description

Update reference home ceiling fans to use label energy use.
Add support for when the rated home has ceiling fan label energy use provided.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@joseph-robertson joseph-robertson self-assigned this Feb 27, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review February 28, 2024 16:27
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@shorowit shorowit merged commit ce93f31 into latest-os-hpxml Feb 28, 2024
@shorowit shorowit deleted the ceiling-fan-watts branch February 28, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants