ANSI 301-2022: Fraction Duct Area #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Jan 24, 2024
There was a problem hiding this comment.
A few changes required.
Also, in tasks.rb, there is a list of OS-HPXML files that we reuse for testing in OS-ERI. Please add base-hvac-ducts-area-fractions.xml to the list and then run openstudio tasks.rb update_measures so that the file is copied over and will get run during CI simulation tests.
shorowit
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Looking much better, thanks @bpark1327. Just a couple more comments/suggestions.
Co-authored-by: Scott Horowitz <[email protected]>
…or OS-HPXML tasks). Small update to docs. [ci skip]
shorowit
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allow FractionDuctArea inputs as alternative to DuctSurfaceArea
PDS01: When duct surface area is not directly measured or taken from detailed ACCA Manual D duct sizing take-offs, total duct area shall be estimated using the following equation... Asupply = 0.27 x CFAserved, Areturn = (if Number of Returns < 6, 0.05 x Number of Returns, 0.25 otherwise) x CFAserved
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
OS-HPXML git subtree has been pulledWorkflow tests have been updatedopenstudio tasks.rb update_measureshas been run