Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI 301-2022: Boilers #708

Merged
merged 8 commits into from
Jan 20, 2024
Merged

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Jan 20, 2024

Pull Request Description

[description here]

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

66c2c1fce0 Typo [ci skip]
406aecb7f5 Merge branch 'ansi_301_2022' of https://github.com/NREL/OpenStudio-HPXML into ansi_301_2022_shared_boilers
e1b7d4dbdf Shared boilers require `SharedLoopWatts` (and `FanCoilWatts` if a fan coil system) inputs; removed EAE inputs/defaults.
79191efd74 Update Changelog.md [ci skip]

git-subtree-dir: hpxml-measures
git-subtree-split: 66c2c1fce0f383ddd50711f28cf665fb9d7af878
c99d167c2b Add calc back in.

git-subtree-dir: hpxml-measures
git-subtree-split: c99d167c2b81b833042e6cefb14e46d1a70efe9f
01c4b571fd Some code refactor.
7d4bb74330 Remove useless assignment [ci skip]

git-subtree-dir: hpxml-measures
git-subtree-split: 01c4b571fd1e08db9cdceb9fbf1bc07ecc2df95c
@shorowit shorowit self-assigned this Jan 20, 2024
@shorowit shorowit merged commit 906da5d into ansi_301_2022 Jan 20, 2024
@shorowit shorowit deleted the ansi_301_2022_shared_boilers branch January 20, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant