Address some review comments.

NREL · Apr 11, 2024 · 054237b · 054237b
1 parent b3cc91a
commit 054237b
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 18 deletions.
diff --git a/tasks.rb b/tasks.rb
@@ -1041,11 +1041,11 @@ def set_hpxml_foundation_walls(hpxml_file, hpxml_bldg)
       return
     elsif hpxml_file.include?('ConditionedBasement')
       if hpxml_file.include?('PhoenixAZ')
-        insulation_exterior_r_value = 0
+        insulation_interior_r_value = 0
       elsif hpxml_file.include?('BaltimoreMD')
-        insulation_exterior_r_value = 10
+        insulation_interior_r_value = 10
       elsif hpxml_file.include?('DuluthMN')
-        insulation_exterior_r_value = 15
+        insulation_interior_r_value = 15
       end
       hpxml_bldg.foundation_walls.add(id: "FoundationWall#{hpxml_bldg.foundation_walls.size + 1}",
                                       exterior_adjacent_to: HPXML::LocationGround,
@@ -1054,10 +1054,10 @@ def set_hpxml_foundation_walls(hpxml_file, hpxml_bldg)
                                       area: 1177.8,
                                       thickness: 6,
                                       depth_below_grade: 7.75,
-                                      insulation_interior_r_value: 0,
+                                      insulation_interior_r_value: insulation_interior_r_value,
                                       insulation_interior_distance_to_top: 0,
                                       insulation_interior_distance_to_bottom: 0,
-                                      insulation_exterior_r_value: insulation_exterior_r_value,
+                                      insulation_exterior_r_value: 0,
                                       insulation_exterior_distance_to_top: 0,
                                       insulation_exterior_distance_to_bottom: 8.5)
     else
@@ -1381,7 +1381,7 @@ def set_hpxml_windows(hpxml_file, hpxml_bldg)
     hpxml_bldg.windows.clear
     if hpxml_file.include?('ReferenceWindows')
       if hpxml_file.include?('MiamiFL')
-        ufactor, shgc = 1.30, 0.40
+        ufactor, shgc = 1.20, 0.40
       elsif hpxml_file.include?('PhoenixAZ')
         ufactor, shgc = 0.75, 0.40
       elsif hpxml_file.include?('SanFranCA')
@@ -2297,12 +2297,11 @@ def set_hpxml_ventilation_fans(hpxml_file, hpxml_bldg)
     if hpxml_file.include?('NoMechVent')
       return
     elsif hpxml_file.include?('CFIS')
-      cooling_flow_rate = 400.0 * (hpxml_bldg.cooling_systems[0].cooling_capacity / 12000) # cfm per 301-2019 Table 4.2.2(1) Note m
       hpxml_bldg.ventilation_fans.add(id: "VentilationFan#{hpxml_bldg.ventilation_fans.size + 1}",
                                       fan_type: HPXML::MechVentTypeCFIS,
                                       tested_flow_rate: 155.4,
                                       hours_in_operation: 12,
-                                      fan_power: (0.58 * cooling_flow_rate).round(3),
+                                      fan_power: 487.2,
                                       used_for_whole_building_ventilation: true,
                                       cfis_addtl_runtime_operating_mode: HPXML::CFISModeAirHandler,
                                       distribution_system_idref: hpxml_bldg.hvac_distributions[0].id,

diff --git a/workflow/tests/RESNET_Tests/4.7_Multi_Climate/05_ConditionedBasement_CZ4A_BaltimoreMD.xml b/workflow/tests/RESNET_Tests/4.7_Multi_Climate/05_ConditionedBasement_CZ4A_BaltimoreMD.xml
@@ -153,13 +153,13 @@
               <SystemIdentifier id='FoundationWall1Insulation'/>
               <Layer>
                 <InstallationType>continuous - exterior</InstallationType>
-                <NominalRValue>10.0</NominalRValue>
+                <NominalRValue>0.0</NominalRValue>
                 <DistanceToTopOfInsulation>0.0</DistanceToTopOfInsulation>
                 <DistanceToBottomOfInsulation>8.5</DistanceToBottomOfInsulation>
               </Layer>
               <Layer>
                 <InstallationType>continuous - interior</InstallationType>
-                <NominalRValue>0.0</NominalRValue>
+                <NominalRValue>10.0</NominalRValue>
                 <DistanceToTopOfInsulation>0.0</DistanceToTopOfInsulation>
                 <DistanceToBottomOfInsulation>0.0</DistanceToBottomOfInsulation>
               </Layer>

diff --git a/workflow/tests/RESNET_Tests/4.7_Multi_Climate/05_ConditionedBasement_CZ7_DuluthMN.xml b/workflow/tests/RESNET_Tests/4.7_Multi_Climate/05_ConditionedBasement_CZ7_DuluthMN.xml
@@ -153,13 +153,13 @@
               <SystemIdentifier id='FoundationWall1Insulation'/>
               <Layer>
                 <InstallationType>continuous - exterior</InstallationType>
-                <NominalRValue>15.0</NominalRValue>
+                <NominalRValue>0.0</NominalRValue>
                 <DistanceToTopOfInsulation>0.0</DistanceToTopOfInsulation>
                 <DistanceToBottomOfInsulation>8.5</DistanceToBottomOfInsulation>
               </Layer>
               <Layer>
                 <InstallationType>continuous - interior</InstallationType>
-                <NominalRValue>0.0</NominalRValue>
+                <NominalRValue>15.0</NominalRValue>
                 <DistanceToTopOfInsulation>0.0</DistanceToTopOfInsulation>
                 <DistanceToBottomOfInsulation>0.0</DistanceToBottomOfInsulation>
               </Layer>

diff --git a/workflow/tests/RESNET_Tests/4.7_Multi_Climate/07_ReferenceWindows_CZ1A_MiamiFL.xml b/workflow/tests/RESNET_Tests/4.7_Multi_Climate/07_ReferenceWindows_CZ1A_MiamiFL.xml
@@ -256,7 +256,7 @@
             <SystemIdentifier id='Window1'/>
             <Area>108.0</Area>
             <Azimuth>0</Azimuth>
-            <UFactor>1.3</UFactor>
+            <UFactor>1.2</UFactor>
             <SHGC>0.4</SHGC>
             <FractionOperable>1.0</FractionOperable>
             <PerformanceClass>residential</PerformanceClass>
@@ -266,7 +266,7 @@
             <SystemIdentifier id='Window2'/>
             <Area>108.0</Area>
             <Azimuth>90</Azimuth>
-            <UFactor>1.3</UFactor>
+            <UFactor>1.2</UFactor>
             <SHGC>0.4</SHGC>
             <FractionOperable>1.0</FractionOperable>
             <PerformanceClass>residential</PerformanceClass>
@@ -276,7 +276,7 @@
             <SystemIdentifier id='Window3'/>
             <Area>108.0</Area>
             <Azimuth>180</Azimuth>
-            <UFactor>1.3</UFactor>
+            <UFactor>1.2</UFactor>
             <SHGC>0.4</SHGC>
             <FractionOperable>1.0</FractionOperable>
             <PerformanceClass>residential</PerformanceClass>
@@ -286,7 +286,7 @@
             <SystemIdentifier id='Window4'/>
             <Area>108.0</Area>
             <Azimuth>270</Azimuth>
-            <UFactor>1.3</UFactor>
+            <UFactor>1.2</UFactor>
             <SHGC>0.4</SHGC>
             <FractionOperable>1.0</FractionOperable>
             <PerformanceClass>residential</PerformanceClass>

diff --git a/workflow/tests/RESNET_Tests/4.7_Multi_Climate/08_CFIS_CZ7_DuluthMN.xml b/workflow/tests/RESNET_Tests/4.7_Multi_Climate/08_CFIS_CZ7_DuluthMN.xml
@@ -400,7 +400,7 @@
               <HoursInOperation>12.0</HoursInOperation>
               <UsedForWholeBuildingVentilation>true</UsedForWholeBuildingVentilation>
               <IsSharedSystem>false</IsSharedSystem>
-              <FanPower>232.0</FanPower>
+              <FanPower>487.2</FanPower>
               <AttachedToHVACDistributionSystem idref='HVACDistribution1'/>
               <extension>
                 <VentilationOnlyModeAirflowFraction>1.0</VentilationOnlyModeAirflowFraction>

diff --git a/workflow/tests/RESNET_Tests/4.7_Multi_Climate/09_CFISDuctsInAttic_CZ7_DuluthMN.xml b/workflow/tests/RESNET_Tests/4.7_Multi_Climate/09_CFISDuctsInAttic_CZ7_DuluthMN.xml
@@ -400,7 +400,7 @@
               <HoursInOperation>12.0</HoursInOperation>
               <UsedForWholeBuildingVentilation>true</UsedForWholeBuildingVentilation>
               <IsSharedSystem>false</IsSharedSystem>
-              <FanPower>232.0</FanPower>
+              <FanPower>487.2</FanPower>
               <AttachedToHVACDistributionSystem idref='HVACDistribution1'/>
               <extension>
                 <VentilationOnlyModeAirflowFraction>1.0</VentilationOnlyModeAirflowFraction>