-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7주차/필수] Compose repository 패턴 #19
base: develop-compose
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿
@Provides | ||
@Singleton | ||
fun provideSharedPref(@ApplicationContext context: Context): SharedPreferences { | ||
return context.getSharedPreferences("userData", Context.MODE_PRIVATE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
키값도 상수로 만들어주면 좋을 것 같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뷰모델에서 코루틴 적용 안 된 부분들도 적용되면 좋을 것 같아용-! 수고하셨습니다 !
@@ -11,6 +11,7 @@ import com.sopt.now.compose.screen.main.MainScreen | |||
import com.sopt.now.compose.ui.theme.NOWSOPTAndroidTheme | |||
import dagger.hilt.android.AndroidEntryPoint | |||
|
|||
@AndroidEntryPoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어떤 어노테이션인가 했더니 이것도 Dagger-Hilt 모듈과 관련된 어노테이션이군요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그만 잘하셍 ㅡㅡ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제 힐트까지 ㄷ.ㄷ 야무지십니당
Related issue 🛠
Work Description ✏️
To Reviewers 📢