Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7주차/필수] Compose repository 패턴 #19

Open
wants to merge 1 commit into
base: develop-compose
Choose a base branch
from

Conversation

leeseokchan00
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • sharedpreferences에 repository 패턴 적용하기

To Reviewers 📢

@leeseokchan00 leeseokchan00 requested a review from a team June 7, 2024 13:11
@leeseokchan00 leeseokchan00 self-assigned this Jun 7, 2024
Copy link

@gaeulzzang gaeulzzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@Provides
@Singleton
fun provideSharedPref(@ApplicationContext context: Context): SharedPreferences {
return context.getSharedPreferences("userData", Context.MODE_PRIVATE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키값도 상수로 만들어주면 좋을 것 같네요

Copy link
Member

@yskim6772 yskim6772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰모델에서 코루틴 적용 안 된 부분들도 적용되면 좋을 것 같아용-! 수고하셨습니다 !

@@ -11,6 +11,7 @@ import com.sopt.now.compose.screen.main.MainScreen
import com.sopt.now.compose.ui.theme.NOWSOPTAndroidTheme
import dagger.hilt.android.AndroidEntryPoint

@AndroidEntryPoint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어떤 어노테이션인가 했더니 이것도 Dagger-Hilt 모듈과 관련된 어노테이션이군요 !

Copy link

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그만 잘하셍 ㅡㅡ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 힐트까지 ㄷ.ㄷ 야무지십니당

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants