Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6주차/필수] Compose 뷰모델을 사용해서 서버통신, UI 로직 분리하기 #16

Open
wants to merge 1 commit into
base: develop-compose
Choose a base branch
from

Conversation

leeseokchan00
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • 뷰모델로 로직 분리하기(이미 적용되어 있습니다.)
  • 분기처리 스코프함수로 변경

Screenshot 📸

Screen_recording_20240524_193950.mp4

Uncompleted Tasks 😅

To Reviewers 📢

코리 반영을 못했습니다. 합세 끝나면 바로 해보겠습니다....

@leeseokchan00 leeseokchan00 requested a review from a team May 24, 2024 10:48
@leeseokchan00 leeseokchan00 self-assigned this May 24, 2024
@leeseokchan00 leeseokchan00 linked an issue May 24, 2024 that may be closed by this pull request
1 task
Copy link
Member

@yskim6772 yskim6772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~!

Comment on lines +36 to 41
response.headers()["location"]?.let {userId ->
MyApplication.userdata.setUserId(USER_ID_KEY, userId.toInt())
_loginState.value = SignInState.Success(R.string.login_screen_success_login)
} ?: run {
_loginState.value = SignInState.Failure(R.string.signup_failure_input)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let과 run 사용으로 널 처리 좋네요 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6주차] 뷰모델을 사용해서 서버통신, UI 로직 분리하기
2 participants