[FEAT/#17] week7-compose / 필수과제 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jun 9, 2024
Comment on lines
+7
to
+15
| class SignUpViewModelFactory(private val signUpRepository: SignUpRepository) : ViewModelProvider.Factory { | ||
| override fun <T : ViewModel> create(modelClass: Class<T>): T { | ||
| if (modelClass.isAssignableFrom(SignUpViewModel::class.java)) { | ||
| @Suppress("UNCHECKED_CAST") | ||
| return SignUpViewModel(signUpRepository) as T | ||
| } | ||
| throw IllegalArgumentException("알 수 없는 ViewModel 클래스") | ||
| } | ||
| } |
There was a problem hiding this comment.
팩토리에서 이 부분이 반복되는 것 같은데 어떻게 반복을 없앨 수 있을지 생각해보면 좋을 것 같아요!
Comment on lines
+20
to
+23
| } | ||
| }.getOrElse { | ||
| Result.failure(it) | ||
| } |
Comment on lines
+20
to
+24
| val result = signUpRepository.signUp(signUpDto) | ||
| _signUpState.value = if (result.isSuccess) { | ||
| SignUpState.Success("회원가입 성공") | ||
| } else { | ||
| SignUpState.Error(result.exceptionOrNull()?.message ?: "회원가입 실패") |
There was a problem hiding this comment.
Suggested change
| val result = signUpRepository.signUp(signUpDto) | |
| _signUpState.value = if (result.isSuccess) { | |
| SignUpState.Success("회원가입 성공") | |
| } else { | |
| SignUpState.Error(result.exceptionOrNull()?.message ?: "회원가입 실패") | |
| signUpRepository.signUp( | |
| signUpDto | |
| ).onSuccess { | |
| _signUpState.value = SignUpState.Success("회원가입 성공") | |
| }.onFailure{ | |
| _signUpState.value = SignUpState.Error(result.exceptionOrNull()?.message ?: "회원가입 실패") | |
| } |
취향차이일 수는 있을 것 같은데 result를 따로 변수화하지 않고도 사용해줄 수 있을 것 같아요!
2hyunjinn
approved these changes
Jun 9, 2024
| val response = chain.proceed(request) | ||
|
|
||
| // 응답 헤더에서 Location 값 추출해서 memberId에 저장 때리기 |
| import com.sopt.now.data.model.RequestLoginDto | ||
| import com.sopt.now.data.model.ResponseLoginDto | ||
|
|
||
| interface LoginRepository { |
| is LoginState.Loading -> CircularProgressIndicator() | ||
| is LoginState.Success -> { | ||
| LaunchedEffect(state.message) { | ||
| Toast.makeText(context, state.message, Toast.LENGTH_LONG).show() | ||
| toast(context, state.message) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌issue
📄Work Description
📷Record
📢To Reviewers