Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] repository 생성 #9

Open
wants to merge 1 commit into
base: develop-xml
Choose a base branch
from
Open

[feat] repository 생성 #9

wants to merge 1 commit into from

Conversation

twogarlic
Copy link
Collaborator

x7.mp4

0se0
0se0 reviewed Jun 9, 2024
View reviewed changes
Copy link
Member

@0se0 0se0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~!!
앱잼 파이팅!!

app/src/main/java/com/sopt/now/ApiFactory.kt
object ApiFactory {
private const val BASE_URL: String = BuildConfig.AUTH_BASE_URL

//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 주석 글 없으니까 // 요거 삭제해두 될 거 같아용

app/src/main/java/com/sopt/now/MyPageFragment.kt

class MyPageFragment: Fragment() {
private var _binding: FragmentMypageBinding? = null
private val binding get() = _binding!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_binding!! 부분 저희 세미나에서 배웠던 것 처럼 이렇게 바꾸면 좋을 거 같아요!!

private val binding: FragmentMyPageBinding
get() = requireNotNull(_binding) { "FragmentMyPageBinding is not initialized" }

app/src/main/java/com/sopt/now/SearchFragment.kt
class SearchFragment: Fragment() {

private var _binding: FragmentSearchBinding? = null
private val binding get() = _binding!!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private val binding: FragmentMyPageBinding
get() = requireNotNull(_binding) { "FragmentMyPageBinding is not initialized" } 여기도 SearchFragment 이름에 맞춰서 이렇게 작성하면 좋을 거 같아요!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0se0 0se0 0se0 left review comments

@Sangwook123 Sangwook123 Awaiting requested review from Sangwook123

@t1nm1ksun t1nm1ksun Awaiting requested review from t1nm1ksun

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twogarlic @0se0