FEAT #7
Open
FEAT #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
고생하셨습니다! |
Sangwook123
suggested changes
May 5, 2024
| } | ||
| val client = OkHttpClient.Builder().addInterceptor(loggingInterceptor).build() | ||
| // | ||
| val retrofit: Retrofit by lazy { |
| Text("회원가입") | ||
| } | ||
| Button( | ||
| onClick = { |
There was a problem hiding this comment.
onClick 내부 코드들 함수화 시켜주시면 좋을 것 같습니다. 이 버튼이 어떤 역할을 하는지 함수명으로 직관으로 알려주면 좋을 것 같아요
| Text( | ||
| text = "Hello $name!", | ||
| modifier = modifier | ||
| fun Scaffold(Id: String?, Password: String?, Nickname: String?, Mbti: String?,City: String?, memberId: String?) { |
| verticalArrangement = Arrangement.spacedBy(16.dp), | ||
| ) { | ||
| when(selectedItem) { | ||
| 0 -> { |
There was a problem hiding this comment.
0, 1, 2같은 Type Code는 클래스로 치환하거나 enum을 활용하시는게 가독성과 유지보수 측면에서 이점이 있을 것 같습니다
0se0
reviewed
May 5, 2024
There was a problem hiding this comment.
여기두 각 기능별로 한 줄씩 띄워주시면 읽기 더 편할 거 같아요!
Comment on lines
109
to
129
| if (response.isSuccessful) { | ||
| val loginResponse = response.body() | ||
| if (loginResponse?.code == 200) { | ||
| val userId = response.headers()["location"] | ||
| Toast.makeText( | ||
| context, | ||
| "로그인 성공! ID는 $userId 입니둥", | ||
| Toast.LENGTH_SHORT, | ||
| ).show() | ||
| val intent = Intent(context, MainActivity::class.java).apply { | ||
| putExtra("memberId", userId) | ||
| } | ||
| context.startActivity(intent) | ||
|
|
||
| } else { | ||
| Toast.makeText(context, "로그인 실패! 아이디와 비밀번호를 다시 확인해주세요.", Toast.LENGTH_SHORT).show() | ||
| } | ||
| } else { | ||
| Toast.makeText(context, "로그인에 실패했습니다!", Toast.LENGTH_SHORT).show() | ||
| } | ||
| } |
There was a problem hiding this comment.
if (response.isSuccessful) 이렇게 응답 성공 조건문이 있으니까
그 안에서 if (loginResponse?.code == 200) 한번 더 검사하지 않아도 될 거 같아요!!
Comment on lines
+105
to
+108
| if (response.isSuccessful) { | ||
| Toast.makeText(context, "비밀번호가 변경되었습니다! 다시 로그인 해주세요", Toast.LENGTH_SHORT).show() | ||
| context.startActivity(Intent(context, LoginActivity::class.java)) | ||
| } else { |
There was a problem hiding this comment.
ResponseChangePasswordDto를 통해 받아온 메세지를 출력하는 방식도 좋을 거 같아요!
l2hyunwoo
suggested changes
May 5, 2024
t1nm1ksun
reviewed
May 7, 2024
| import retrofit2.http.PATCH | ||
| import retrofit2.http.POST | ||
|
|
||
| interface AuthService { |
There was a problem hiding this comment.
API명세서에 회원정보에 관한 내용을 이용해 회원정보를 가져올 수 있을것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시연 영상
compose.mp4
viewmodel 적용되어있습니다