Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1차 세미나/xml] : 심화 과제 #5

Merged
merged 19 commits into from
Apr 15, 2024
Merged

[1차 세미나/xml] : 심화 과제 #5

merged 19 commits into from
Apr 15, 2024

Conversation

Eonji-sw
Copy link
Member

@Eonji-sw Eonji-sw commented Apr 7, 2024 •
edited
Loading

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

  • activity 생명주기 알아보기
  • viewModel 사용해서 state 관리하기
  • 유저에게 더 좋은 경험 제공하기 택 1
    • 뒤로가기시 로그인 화면
    • 텍스트 입력시 2줄 방지
    • 키보드가 올라올 때 버튼 가림 방지
    • 클릭시 리플효과 방지(compose)

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

1._._xml.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

@Eonji-sw Eonji-sw self-assigned this Apr 7, 2024
@Eonji-sw Eonji-sw added ⭐ [FEAT] 새로운 기능 구현 💟 [UI] UI 작업 xml 파일 ⚙️ [SETTING] 세팅 🥈 심화 과제 심화 과제 ☘️ xml xml labels Apr 7, 2024
@Eonji-sw Eonji-sw requested a review from chanubc April 13, 2024 17:11
sohyun127
sohyun127 approved these changes Apr 13, 2024
View reviewed changes
Copy link

@sohyun127 sohyun127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놀러왔슴다

@Eonji-sw Eonji-sw requested a review from sohyun127 April 13, 2024 17:14
seohee0925
seohee0925 approved these changes Apr 13, 2024
View reviewed changes
Copy link

@seohee0925 seohee0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우왓..... 뷰모델에 대해서 하나도 몰랐는데 언지 코드 보고 좀 이해됐어요........ 이외에도 변수명이나 함수명이 명확해서 코드 리뷰하기 수월했어용 수고 많았어요 최고의 오비 💟

app/src/main/java/com/sopt/now/presentation/MainActivity.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/MainActivity.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/sign/SignViewModel.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/login/LoginActivity.kt Show resolved Hide resolved
leeeyubin
leeeyubin approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심화과제까지 넘 수고했어요!!

app/src/main/java/com/sopt/now/presentation/util/KeyStorage.kt Show resolved Hide resolved
chanubc
chanubc approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@chanubc chanubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

놀러왔슴다

app/src/main/java/com/sopt/now/presentation/login/LoginActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/login/LoginViewModel.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/login/LoginViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/sign/SignViewModel.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/sign/SignActivity.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/login/LoginActivity.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/login/LoginActivity.kt Show resolved Hide resolved
Hyobeen-Park
Hyobeen-Park approved these changes Apr 13, 2024
View reviewed changes
Copy link

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 이해하기 쉽고 깔끔해서 너무 좋았어요!! 뷰모델에 대해서도 조금 더 잘 이해할 수 있게 된 것 같아요 언지 최고다!!!!!!!!

app/src/main/java/com/sopt/now/presentation/MainActivity.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/sign/SignViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/sopt/now/presentation/sign/SignViewModel.kt Show resolved Hide resolved
app/src/main/java/com/sopt/now/core/util/view/UiState.kt Show resolved Hide resolved
@Eonji-sw Eonji-sw merged commit 76b2716 into develop-xml Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haeti-dev haeti-dev haeti-dev left review comments

@leeeyubin leeeyubin leeeyubin approved these changes

@chanubc chanubc chanubc approved these changes

@seohee0925 seohee0925 seohee0925 approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@kez-lab kez-lab Awaiting requested review from kez-lab

@sohyun127 sohyun127 Awaiting requested review from sohyun127

Assignees

@Eonji-sw Eonji-sw

Labels
⭐ [FEAT] 새로운 기능 구현 ⚙️ [SETTING] 세팅 💟 [UI] UI 작업 xml 파일 ☘️ xml xml 🥈 심화 과제 심화 과제
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Eonji-sw @sohyun127 @Hyobeen-Park @haeti-dev @seohee0925 @chanubc @leeeyubin