Skip to content

Commit

Permalink
gh: rm submodule build steps
Browse files Browse the repository at this point in the history
  • Loading branch information
program-- committed Jan 25, 2024
1 parent 3827696 commit 341c03b
Showing 1 changed file with 0 additions and 89 deletions.
89 changes: 0 additions & 89 deletions .github/workflows/test_and_validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,6 @@ jobs:
with:
mod-dir: "extern/bmi-cxx/"

- name: Build Submodules
id: submod_build
uses: ./.github/actions/ngen-submod-build
with:
mod-dir: "extern/test_bmi_cpp/"
targets: "testbmicppmodel"

- name: Build Unit Tests
uses: ./.github/actions/ngen-build
with:
Expand All @@ -153,11 +146,6 @@ jobs:
- name: Clean Up Unit Test Build
uses: ./.github/actions/clean-build

- name: Clean Up Submodule Build
uses: ./.github/actions/clean-build
with:
build-dir: ${{ steps.submod_build.outputs.build-dir }}

# Run BMI C tests in linux environment, and separating to isolate
test_bmi_c:
# The type of runner that the job will run on
Expand All @@ -172,13 +160,6 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3

- name: Build Submodules
id: submod_build
uses: ./.github/actions/ngen-submod-build
with:
mod-dir: "extern/test_bmi_c"
targets: "testbmicmodel"

- name: Build Unit Tests
uses: ./.github/actions/ngen-build
with:
Expand All @@ -198,11 +179,6 @@ jobs:
- name: Clean Up Unit Test Build
uses: ./.github/actions/clean-build

- name: Clean Up Submodule Build
uses: ./.github/actions/clean-build
with:
build-dir: ${{ steps.submod_build.outputs.build-dir }}

# As with the BMI C ubuntu job, separate Fortran in linux tests to keep setups clean and cause of failures clear.
test_bmi_fortran:
# The type of runner that the job will run on
Expand All @@ -217,18 +193,6 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3

# - name: Build Submodules
# id: submod_build_1
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/test_bmi_fortran/"
#
# - name: Build Submodules
# id: submod_build_2
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/iso_c_fortran_bmi/"

- name: Build Unit Tests
uses: ./.github/actions/ngen-build
with:
Expand All @@ -248,14 +212,6 @@ jobs:
- name: Clean Up Unit Test Build
uses: ./.github/actions/clean-build

# - name: Clean Up Submodule Build
# uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_1.outputs.build-dir }}
# - uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_2.outputs.build-dir }}

# As with the BMI C ubuntu job, separate Python in linux tests to keep setups clean and cause of failures clear.
test_bmi_python:
# The type of runner that the job will run on
Expand Down Expand Up @@ -305,37 +261,6 @@ jobs:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v3

# - name: Build Submodules
# id: submod_build_1
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/test_bmi_fortran/"

# - name: Build Submodules
# id: submod_build_2
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/iso_c_fortran_bmi/"

# - name: Build Submodules
# id: submod_build_3
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/test_bmi_c/"
# targets: "testbmicmodel"

#make sure cxx bmi is initialized/ready
# - uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/bmi-cxx/"

# - name: Build Submodules
# id: submod_build_4
# uses: ./.github/actions/ngen-submod-build
# with:
# mod-dir: "extern/test_bmi_cpp/"
# targets: "testbmicppmodel"

- name: Build Unit Tests
uses: ./.github/actions/ngen-build
with:
Expand All @@ -355,20 +280,6 @@ jobs:
- name: Clean Up Unit Test Build
uses: ./.github/actions/clean-build

# - name: Clean Up Submodule Build
# uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_1.outputs.build-dir }}
# - uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_2.outputs.build-dir }}
# - uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_3.outputs.build-dir }}
# - uses: ./.github/actions/clean-build
# with:
# build-dir: ${{ steps.submod_build_4.outputs.build-dir }}


# TODO: fails due to compilation error, at least in large part due to use of POSIX functions not supported on Windows.
# TODO: Need to determine whether Windows support (in particular, development environment support) is necessary.
Expand Down

0 comments on commit 341c03b

Please sign in to comment.