-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Add code version data to outputs #1426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran stage- and flow-based CatFIM with this branch and the two new columns populated as expected. |
EmilyDeardorff
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with stage- and flow-based CatFIM, populated new columns as expected.
…into dev-catfim-versions
CarsonPruitt-NOAA
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new input args to add hand version and catfim version as output columns to all four output files of FB sites and library plus SB sites and library.
The "model_version", when populated will show something similar to "HAND 4_5_11_1".
The "product_version", when populated will show something similar to "CatFIM 2_2". This reflects the interval version number that has been assigned to the CatFIM product in the past few versions.
In HydroVIS, they already have a "model_version" field but having it hear allows us for more accurate testing and debugging only. It will not be used in the HV side.
The new "product_version" field was a request from Derek and it is unknown if it will eventually become a field in HV. It may becomes a rest field but not a web / popup based field. TBD
Changes
tools\catfim
Testing
Ran against any huc and ensure all four output files have those fields and expected values.
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)