Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or edit multiple __set__ functions. #150

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

TimothyCera-NOAA
Copy link
Contributor

  • Created a _calculate_scale_factor function in templates.py to be used in the new ValueOf* set functions.
  • Added set functions to all the ValueOf* classes that behind the scenes use the ScaledValue* and ScaleFactor* setters.
  • Changed the ValueOf* get to behind the scenes use the ScaledValue* and ScaleFactor*
  • Fixed the LeadTime set for messages that are an accumulating statistic to set both LeadTime to the beginning of the accumulating period and the accumulating end date to the appropriate parts of section4.
  • Now when writing with to_grib2 the messages will be sorted, if writing from a DataSet will sort on shortName, then for each DataArray will sort on dimension names, then sort dimension values.

* Created a _calculate_scale_factor function in templates.py to
  be used in the new ValueOf* __set__ functions.
* Added __set__ functions to all the ValueOf* classes that behind the
  scenes use the ScaledValue* and ScaleFactor* setters.
* Changed the ValueOf* __get__ to behind the scenes use the
  ScaledValue* and ScaleFactor
* Fixed the LeadTime __set__ for messages that are an accumulating
  statistic to set both LeadTime to the beginning of the accumulating
  period and the accumulating end date to the appropriate parts of
  section4.
* Now when writing with to_grib2 the messages will be sorted, if writing
  from a DataSet will sort on shortName, then for each DataArray will
  sort on dimension names, then sort dimension values.
@EricEngle-NOAA EricEngle-NOAA merged commit e67a9be into NOAA-MDL:master Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants