Set kwargs["_xarray_backend"], an assert to ValueError, removed if. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not using the xarray backend, in some situations the kwargs["_xarray_backend"] throws a KeyError. Fixed that if not available setting to False, which is the default. If opening a GRIB v1 file, there was an AssertionError which is changed to raise an error and offer an error message. Removed an unnecessary if block that tested for a header which is now done in a loop immediately before.
EricEngle-NOAA
pushed a commit
that referenced
this pull request
Jan 22, 2024
…126) If not using the xarray backend, in some situations the kwargs["_xarray_backend"] throws a KeyError. Fixed that if not available setting to False, which is the default. If opening a GRIB v1 file, there was an AssertionError which is changed to raise an error and offer an error message. Removed an unnecessary if block that tested for a header which is now done in a loop immediately before. Co-authored-by: Tim Cera <[email protected]>
EricEngle-NOAA
added a commit
that referenced
this pull request
Jan 22, 2024
* Adding MRMS GRIB2 tables. This commit provides support for MRMS GRIB2 tables. MRMS uses the GRIB2 discipline value of 209. The included UserTable_MRMS_v12.2.csv contains more information than what is needed, so in time, other attributes from the table can be added. This commit references issue #120 * Adding section4_discipline209.py This commit adds section4_discipline209.py which contains the MRMS variable parameter dictionaries. This commit references issue #120 * Adding support for Gzip GRIB2 files. This commit added support for reading GRIB2 files that have also been gzipped. Some datasets gzip GRIB2 files even though there is no benefit in doing so. When using the grib2io xarray backend, an error will be raised when using Gzipped GIRB2 files. This is a restiction within xarray. This commit references issue #119 * Set kwargs["_xarray_backend"], an assert to ValueError, removed if. (#126) If not using the xarray backend, in some situations the kwargs["_xarray_backend"] throws a KeyError. Fixed that if not available setting to False, which is the default. If opening a GRIB v1 file, there was an AssertionError which is changed to raise an error and offer an error message. Removed an unnecessary if block that tested for a header which is now done in a loop immediately before. Co-authored-by: Tim Cera <[email protected]> --------- Co-authored-by: Eric Engle <[email protected]> Co-authored-by: TimothyCera-NOAA <[email protected]> Co-authored-by: Tim Cera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not using the xarray backend, in some situations the kwargs["_xarray_backend"] throws a KeyError. Fixed that if not available, setting to False, which is the default.
If opening a GRIB v1 file, there was an AssertionError which is changed to raise an error and offer an error message.
Removed an unnecessary if block that tested for a header which is now done in a loop immediately before.