Add a missing call to set the io_domain #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very, very old bug that was encountered by @kshedstrom
When trying to output the
u_atmandv_atmdiagnostics, they ended up with a file per PE rather than 1 file. This is the relevant diag manager code:https://github.com/NOAA-GFDL/FMS/blob/main/diag_manager/diag_output.F90#L129-L153
Because an io domain is not defined each PE writes its own file. Normally, this will cause a crash because fms2_io requires an io domain.
Fixes #NOAA-GFDL/FMS#1508