[QOL] Streamline linting workflow #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting should give fast feedback. The current wokflow took almost 3 minutes where most time is spent installing (unnecessary) python packages. To run `pre-commit` we only need the source files and `pre-commit`, which can be installed standalone. This brings the runtime down to ~30 seconds. Other changes: - update checkout action to v4 - update python setup action to v5 - change python version from 3.11.7 to 3.11 (any patch number will do)
|
@FlorianDeconinck just something I stumbled across in the other PR today. Please review and pull in others (Rusty / Frank) as needed. I am not allowed to request reviews. |
FlorianDeconinck
approved these changes
Jan 28, 2025
bensonr
approved these changes
Jan 29, 2025
|
@fmalatino what do you think? all good? |
fmalatino
approved these changes
Feb 10, 2025
8 tasks
romanc
added a commit
to romanc/NDSL
that referenced
this pull request
Feb 12, 2025
Linting should give fast feedback. The current workflow takes ~3mins where most of the time is spent installing (unnecessary) python packages. To run `pre-commit`, we only need the source files and `pre-commit`itself, which can be installed standalone. This brings runtime of the linting stage down to ~30 seconds. Other changes - update checkout action to v4 - update python setup action to v5 - change python version from 3.11.7 to 3.11 (any patch number will do) This is a follow-up of PR NOAA-GFDL/PyFV3#40 in PyFV3.
7 tasks
romanc
added a commit
to NOAA-GFDL/NDSL
that referenced
this pull request
Feb 12, 2025
Linting should give fast feedback. The current workflow takes ~3mins where most of the time is spent installing (unnecessary) python packages. To run `pre-commit`, we only need the source files and `pre-commit` itself, which can be installed standalone. This brings runtime of the linting stage down to ~30 seconds. Other changes - update checkout action to v4 - update python setup action to v5 - change python version from 3.11.7 to 3.11 (any patch number will do) This is a follow-up of PR NOAA-GFDL/PyFV3#40 in PyFV3. Co-authored-by: Roman Cattaneo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linting should give fast feedback. The current workflow took almost 3 minutes where most time is spent installing (unnecessary) python packages. To run
pre-commitwe only need the source files andpre-commit, which can be installed standalone. This brings the total runtime of this action down to ~30 seconds.Other changes:
How Has This Been Tested?
Tested new action in a PR inside my fork.
Checklist: