[F32] Divergence Damping #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extraneous subset slicing in translate test
bensonr
approved these changes
Dec 11, 2024
oelbert
reviewed
Dec 16, 2024
| @@ -60,13 +60,3 @@ def compute_from_storage(self, inputs): | |||
| ) | |||
| self.divdamp(**inputs) | |||
| return inputs | |||
|
|
|||
| def subset_output(self, varname: str, output): | |||
There was a problem hiding this comment.
Was this really only for NaNs?
There was a problem hiding this comment.
That's my conclusion. The damping is an all domain op, so I don't know why it would require any subseting apart from the fact that the halos carry some NaNs in the translate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure scalars are properly type so 64-bit computation does not bleed into a 32-bit based computation
Also, removed an extraneous subset slicing in translate test which was a previous strategy to deal with expected NaNs in the test data
This should not change 64-bit calculations and therefore is ready for
developChecklist: