Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F32] UpdateDzD #35

Merged

Conversation

FlorianDeconinck
Copy link
Collaborator

  • Fix to flux gradient operation priority for 32-bit float computation.
  • Fix python computation to match floating point precision of the rest of the system
  • Verbose error message for unimplemented options

Should still validate the 64-bit translate dataset but could also trickle to failing DynCore - in which case this will have to wait for the new f32 dataset

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

Fix F32 pure python computation for beta, gamma
Update not implemented with more strict message
@bensonr bensonr requested a review from oelbert December 9, 2024 20:28
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the calculations done outside of stencils but that's not a this-PR issue

@FlorianDeconinck
Copy link
Collaborator Author

I don't love the calculations done outside of stencils but that's not a this-PR issue

Agreed there's a few like this peppered in the dycore

@FlorianDeconinck FlorianDeconinck merged commit 7914a94 into NOAA-GFDL:develop Dec 18, 2024
4 checks passed
@FlorianDeconinck FlorianDeconinck deleted the fix/F32/UpdateDzD branch December 18, 2024 14:31
@FlorianDeconinck FlorianDeconinck restored the fix/F32/UpdateDzD branch January 20, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants