Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QOL] Logging, Type Hints and Quantity helpers #108

Merged
merged 3 commits into from
Feb 11, 2025
Merged

[QOL] Logging, Type Hints and Quantity helpers #108

merged 3 commits into from
Feb 11, 2025

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Feb 10, 2025 •
edited
Loading

  • Type hint logging properly
  • Custom logger for rank 0
  • Clean up noisy logging on MPI comms
  • Added a Quantity level to_netcdf has a shortcut to debugging tools (support multi-rank)
  • Update type hints to resolve inconsistencies

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck
Log on rank 0
2fd2dc8 
Docstrings & typi hints on logger
Stencil Config has a `verbose` option
On verbose: FrozenStencil log when run (in GT backends)
@FlorianDeconinck
Update config in orchestrate call to solve type hint inconcistencies
0d67898
@FlorianDeconinck
Quantity helper to_netcdf with multi rank support
24b1bdc
@FlorianDeconinck FlorianDeconinck merged commit 0aa1775 into NOAA-GFDL:develop Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensonr bensonr bensonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianDeconinck @bensonr