Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Direct Linking to COM from DATA for
wavepostsbs
Job #3303base: develop
Are you sure you want to change the base?
Remove Direct Linking to COM from DATA for
wavepostsbs
Job #3303Changes from 30 commits
c0ec095
e8ddc88
f2669df
b06793b
a417365
66269bd
5f59736
13dca27
f7d3bfc
971cafb
53f7378
a674b8b
173d413
514fd35
2b2c234
007e1ac
849feb7
ae24fbd
dc52172
cf52ba5
20e2808
519767e
ec3dca7
79b2926
901860f
89f6112
b9978c3
b5eaebb
f53e11c
f3d9244
92f4ea5
2b73e50
eb3f5f1
3a03f57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaMeixner-NOAA What this does is copying the
${outfile}
to the COM directory, after theGRIB packing program
is run. We are trying to first run theGRIB packing program
in the working directory and then move thegrib
and.idx
files to the COM dir. Is this what you are concerned about?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! Thanks for these updates. What I'm concerned with is if the grib and .idx files do not exist, then perhaps that should be an error message and not just simply a " echo "${outfile} and ${outfile}.idx not found" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaMeixner-NOAA
"${outfile} and ${outfile}.idx not found in ${GRIBDATA} to copy to COM
Currently, this is the error message. What changes would you recommend for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it say something like "ERROR: explanation" and then exit instead of continuing on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaMeixner-NOAA I will revise the script based on your suggestion. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaMeixner-NOAA I reviewed the script again, and it turns out the issue is addressed in the if blocks (L233-256). However, it only checks the COM files. So, I think your suggestion is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the com_dir be removed from this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JessicaMeixner-NOAA After the L255 the
grib
and the.idx
files should be in both the COM directory and the working directory, since the working directory is not removed yet. So, this should run without an error if those files exist in both dirs. If @aerorahul thinks this is not correct I can change it. But I think this should be correct because we need an alert to send for the files available in COM dir, while checking the files in the working directory.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just an echo. its fine to be either. the crucial line is the
dbn_alert
that alerts the correct path of this file fromcom_dir
.