-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZTD bufr2ioda python tool and "obs space" yaml in rrfsv2-workflow #299
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @HuiLiu-NOAA! It is my understanding that this PR is meant to get the yaml established in RDASApp and that there will be more updates to come. I think there are more QC filters that will need to go in, but this is a great starting point! I do have a few comments/suggestions for its current form.
- Can you refer to some of the validated yamls in RDASApp and follow that style? This is just my own personal preference, but I would like to see a single line (possibly at most two lines) comment before each filter. For example, you can call your step 1
# Pre-online regional domain check (latitude)
and# Pre-online regional domain check (longitude)
respectively. - I believe we're going to stop (as of yesterday or so) naming any netcdf files with the
.nc4
extension. We should just use.nc
. - The jdiag name will be renamed, but we need to hash that out with PR284.
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
This json file should be generic for all bufr2ioda python converters.
a few minor updates.
add vertical coordinate option for FV3-JEDI.
updated comments.
@HuiLiu-NOAA It appears the goal of this PR is not clear enough. It is trying to solve a couple of issues in one PR. Let's discuss this and find a better way to commit these changes. |
Moved the slightly revised SATWND python tool to a new separated PR. |
will move this to a new PR.
remove these lines not necessary for ZTD obs.
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Show resolved
Hide resolved
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to add more QC filters? I can think of a couple that you may want to try.
rrfs-test/validated_yamls/templates/obtype_config/gnss_zenithTotalDelay.yaml
Outdated
Show resolved
Hide resolved
Yes, more QC filters will be added as the evaluation continues. Your suggestions are very welcome. |
You don't have to add these right now since you're just getting the yaml established and you plan to do more testing, but here are a few of my thoughts. These are based on what I have in the conventional obs yamls which I think should still apply.
|
This PR adds a bufr2ioda python tool and an "obs space" of jedivar yaml for ZTD obs.