Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unity normalization; add error catch if more than one normalization type is specified #41

Merged
merged 2 commits into from
Apr 27, 2021
Merged

use unity normalization; add error catch if more than one normalization type is specified #41

merged 2 commits into from
Apr 27, 2021

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Apr 15, 2021 •
edited
Loading

Switch to using unityone normalization in ufs for all fields
Add model abort if more than one normalization type is specified for any n1:n2:maptype

CMEPs Issues:

#38
#40

Description of changes

  • implements unity normalization by changing normalization type for all fields in esmFldsExchange_nems_mod.F90 from none to one
  • adds error catch if more than one normalization type is specified for a given map type between two components. For example attempting to set the normalization of Sa_pslv to "none" in this branch produces the following error message in the PET logs.
20210415 123018.685 INFO             PET000  Map type consf, destcomp atm,  mapnorm ofrac  So_t
20210415 123018.685 INFO             PET000  Map type consf, destcomp atm,  mapnorm ifrac  Faii_evap
20210415 123018.687 INFO             PET000  Map type consf, destcomp ocn,  mapnorm one  Faxa_lat
20210415 123018.687 INFO             PET000  Map type consf, destcomp ocn,  mapnorm one set; cannot set mapnorm to none  Sa_pslv
20210415 123018.687 INFO             PET000 Finalizing ESMF

@DeniseWorthen
use unity normalization and error catch
614f9e8 
* switch to using unityone normalization in ufs for all fields
* add model abort if more than one normalization type is
specified for a single n1:n2:maptype
@DeniseWorthen DeniseWorthen mentioned this pull request Apr 15, 2021
Merged
13 tasks
@DeniseWorthen DeniseWorthen self-assigned this Apr 15, 2021
@DeniseWorthen DeniseWorthen changed the title use unity normalization and error catch use unity normalization; add error catch if more than one normalization type is specified Apr 15, 2021
@DeniseWorthen DeniseWorthen merged commit 037cbe9 into NOAA-EMC:emc/develop Apr 27, 2021
@DeniseWorthen DeniseWorthen deleted the feature/unity_normalization branch January 10, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@binli2337 binli2337 binli2337 approved these changes

Assignees

@DeniseWorthen DeniseWorthen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeniseWorthen @binli2337 @junwang-noaa