Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkgdown fix with ROracle #99

Merged
merged 16 commits into from
Apr 15, 2024
Merged

Pkgdown fix with ROracle #99

merged 16 commits into from
Apr 15, 2024

Conversation

andybeet
Copy link
Member

ROracle fix

  • Needed a new yml file to run on linux machine
  • Needed several system dependencies added

Pkgdown

  • rgdal no longer on CRAN so can't install as a dependency
  • Fixed vignettes that depended on rgdal to use sf instead

andybeet and others added 16 commits October 12, 2023 09:24
@andybeet
Merge pull request #93 from NOAA-EDAB/dev_branch
7af2684 
new simulated datasets from dev --> master
@andybeet
Merge pull request #95 from NOAA-EDAB/dev_branch
080c950 
added library(mscatch) to rmd
@andybeet
Merge pull request #97 from NOAA-EDAB/dev_branch
d189e2d 
spaces in filenames replaced by underscore
@gustavdelius
Add all simulation data sets to _pkgdown.yml
127ba41
@andybeet
Merge pull request #98 from gustavdelius/add_to_pkgdown
13d4fa1 
Add all simulation data sets to _pkgdown.yml
@andybeet
fix for pkgdown when including roracle as a dependency
673087b
@andybeet
install remotes in pkgdown workflow
e425815
@andybeet
typo in NEFSC-Spatial package location
dc44340
@andybeet
rework workflow to avoid using pak
66974ed
@andybeet
install dependencies on linux
46f3166
@andybeet
remove install from binary option
bdfa596
@andybeet
removed all binary install options. Not valid on Linux
9483eca
@andybeet
add libcurl as system dependency
56ee513
@andybeet
add gdal as system dependency
858c355
@andybeet
removed rgdall dependency since it is no longer on CRAN. changed yml …
9e82c9a 
…to allow figure referncing
@andybeet
removed build gh_pages from personal branch
e89de81
@andybeet andybeet requested a review from sgaichas April 12, 2024 23:21
@andybeet
Copy link
Member Author

@sgaichas The pkgdown site is live. Can you check it out to make sure your sim data sets are documented? once approved i'll just merge this into the main branch

sgaichas
sgaichas approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @andybeet
I can see all the new FW dataset descriptions and the additions to the vignette.

@andybeet andybeet merged commit 89123c3 into dev_branch Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgaichas sgaichas sgaichas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andybeet @sgaichas @gustavdelius