Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General catalog revisions in preparation for report sendoff to SSCs #160

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

BBeltz1
Copy link
Collaborator

@BBeltz1 BBeltz1 commented Mar 7, 2025

  • Full page-by-page reference pass and update of .bib file
  • Activation of 2024 observation synthesis page
  • Batch of more complex revisions requested during SOE 2025 Catalog Review
  • Language pass to follow all known guidelines and suggestions
  • Contributor attribution pass to align with survey responses/preferences

@BBeltz1 BBeltz1 requested a review from sgaichas March 7, 2025 22:23
Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BBeltz1 I think I'm missing something

 bookdown::render_book("index.Rmd")
Error in file(con, "r") : cannot open the connection
In addition: Warning message:
In file(con, "r") :
  cannot open file 'chapters/observation_synthesis.rmd': No such file or directory

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Mar 10, 2025

@sgaichas I believe this is because you are inputting bookdown::render_book("index.rmd"), which is trying to use the previous "index.rmd" file instead of rebuilding it. Try using bookdown::render_book() and let me know if you get the same error. Same goes for tech doc.

@andybeet
Copy link
Member

andybeet commented Mar 10, 2025

There is no observation_synthesis.rmd page in this branch.
But there are observation_synthesis_2023.rmd and observation_synthesis_2024.rmd

And it looks like the current synthesis has an indicator name of other in the issue. This just needs to be changed, the page built from the issue, and pushed

Copy link
Member

@sgaichas sgaichas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds now, thank you! looks good on spot checks

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Mar 10, 2025

Thanks Sarah.

@andybeet the observations page marked Other is the page for next year and is deactivated (removed "Submission" tag).

@BBeltz1 BBeltz1 merged commit deaf66e into dev Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants