-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ome.ps.as2 benchmark vs. Pegasus #373
Conversation
@felixhekhorn Yes, no problem at all. |
The problem is somewhere in the CA part (i.e. putting that to 0 in both side, makes the test pass) |
@igborsa as the CI shows with the last commit we are now passing the benchmark - so I think you should do the same on your side. Just to rephrase what @giacomomagni already said on #368 : we are using two different representation of the same object and your fix for In practice you just need to revert that line. |
Hi @felixhekhorn. Actually, the fix is needed. The routine ACG3(N) returns the Mellin transform already evaluated in N+1, so using ACG3(N1) would return the result evaluated in N+2 (that's what confused me when I listed the potential bugs). The correct "translation" to the eko routines is indeed ACG3(N) = h.g_functions.mellin_g3(N1, S11) and that's why your last modification worked. |
I see ... but this means the remaining difference we have between us must come from somewhere else then |
It seems that (at least part of) the difference we have is actually coming from the term \beta''(N+1) in A_Hg. Replacing BET2(N+1) -> (DPSI((N1+1)/2.d0,2) - DPSI(N1/2.d0,2))/8.d0, where DPSI(N,2) corresponds to the second derivative of the Digamma, seems to improve the agreement between eko and pol-pegasus |
@igborsa is it okay if I copy your implementation of the polarized NNLO OME here?
As will be visible in the CI the benchmark fails in the last line - commenting that line out, we pass
The error will be