Skip to content

Commit

Permalink
Release 2024120201 (#73)
Browse files Browse the repository at this point in the history
* Version bump to 2024100801

* DI-6986 Fix the breadcrumb home links and footer (#72)

* DI-6986 Remove footer debug

* DI-6986 Fix the non standard breadcrumb home link
  • Loading branch information
marcinca authored Dec 9, 2024
1 parent 45a0bb8 commit b3cacc5
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 14 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# NHSE Theme change log

## 2024-12-02.01
1. Footer debug tweaks

## 2024-10-08.01

1. Integrated NHSUK Frontend Framework 9.x (BOOST child theme)
Expand Down
24 changes: 14 additions & 10 deletions classes/output/core_renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

namespace theme_nhse\output;

//use block_contents;
use context_course;
use navigation_node;

//use block_contents;
//use custom_menu;
//use custom_menu_item;
//use html_writer;
//use moodle_url;
use navigation_node;
//use theme_boost\boostnavbar;

defined('MOODLE_INTERNAL') || die;

Expand Down Expand Up @@ -96,13 +96,17 @@ public function footer()

public function other_info()
{
$layout = $this->get_page()->pagelayout;
$pagetype = $this->get_page()->pagetype;
$title = $this->page_title();

return "<span>Page title: {$title}<span><br>
<span>Page layout: {$layout}</span><br>
<span>Page type: {$pagetype}</span>";
if (debugging(null, DEBUG_DEVELOPER) and has_capability('moodle/site:config', \context_system::instance())) {
$layout = $this->get_page()->pagelayout;
$pagetype = $this->get_page()->pagetype;
$title = $this->page_title();

return "<span>Page title: {$title}<span><br>
<span>Page layout: {$layout}</span><br>
<span>Page type: {$pagetype}</span>";
} else {
return '';
}
}

/**
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "nhsla/moodle-nhse",
"type": "moodle-theme",
"version": "2024100801",
"version": "2024120201",
"require": {
"composer/installers": "~1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion config.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
//$THEME->lessvariablescallback = 'theme_more_less_variables';
//$THEME->extralesscallback = 'theme_more_extra_less';
$THEME->name = 'nhse';
$THEME->version = '2024100801';
$THEME->version = '2024120201';
$THEME->parents = ['boost'];
$THEME->regions = [];
$THEME->sheets = [];
Expand Down
2 changes: 1 addition & 1 deletion templates/core/navbar.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<ol class="nhsuk-breadcrumb__list">
{{^get_items}}
<li class="nhsuk-breadcrumb__item">
<a href="{{{config.homeurl}}}courses.php" class="nhsuk-breadcrumb__link">
<a href="{{{config.homeurl}}}" class="nhsuk-breadcrumb__link">
<span class="media-left"><i class="icon fa fa-home fa-fw" aria-hidden="true"></i>
</span>My courses</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
defined('MOODLE_INTERNAL') || die();

// This is the version of the plugin.
$plugin->version = 2024100801;
$plugin->version = 2024120201;
$plugin->release = '404.4.0';
$plugin->maturity = MATURITY_BETA;

Expand Down

0 comments on commit b3cacc5

Please sign in to comment.