Updates fixing Hazus Hurricane assessment with both wind and flood demands #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 426557b.
This does lead to unnecessary warnings when some components use loss models while others use damage & consequence models. However, in every other case, these warnings are useful to recognize that something went wrong. I will try to figure out a way to avoid the unnecessary warnings.
DLC used to only save the losses from consequence functions for backwards compatibility. Now that we have loss functions as an alternative and sometimes both are used in the same simulation, it was important to have both results combined and saved in the end.
This includes the following changes: - Add support for multiple loss model files assigned to a single built-in analysis type because Hazus Hurricane needs both wind and flood loss data. - Update loss map preparation to use the asset sample (instead of the damage sample) so that we get all assigned components into the loss map. - Leverage the new loss combination feature by making it available through DL calculation and providing default combination matrix for users of the Hazus Hurricane assessment. (The replacement threshold configurations are also exposed, but not yet used in DL calculation) - The Damage and Loss Model Library was also updated and several bugs were fixed related to this feature. The corresponding changes are described in the commits in that repo. - Add the flood model file to the list of bundled resources
I am not sure why these were turned off. The corresponding tests were also updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages for details