Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use submodule files. #87

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Use submodule files. #87

merged 6 commits into from
Dec 13, 2024

Conversation

ioannis-vm
Copy link
Contributor

No description provided.

@ioannis-vm ioannis-vm force-pushed the 2024-12_use_submodule_files_v2 branch from 739fa83 to b84bd97 Compare December 6, 2024 12:46
zsarnoczay
zsarnoczay reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@zsarnoczay zsarnoczay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I have two small questions.

pelicun/file_io.py Outdated Show resolved Hide resolved
pelicun/file_io.py Outdated Show resolved Hide resolved
zsarnoczay
zsarnoczay approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@zsarnoczay zsarnoczay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge.

@zsarnoczay zsarnoczay merged commit cdfc6ec into NHERI-SimCenter:develop Dec 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsarnoczay zsarnoczay zsarnoczay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioannis-vm @zsarnoczay