-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn warning into an error. #83
Closed
ioannis-vm
wants to merge
45
commits into
NHERI-SimCenter:develop
from
ioannis-vm:2024-12_update_warning
Closed
Turn warning into an error. #83
ioannis-vm
wants to merge
45
commits into
NHERI-SimCenter:develop
from
ioannis-vm:2024-12_update_warning
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannis-vm
force-pushed
the
2024-12_update_warning
branch
from
December 6, 2024 11:46
c7dd540
to
77980e8
Compare
Build the docs based on the `master` branch instead of the `docs` branch.
Now RVs in the UQ module support variable parameters, meaning that in each realization a value can be drawn from the same family but with predefined parameters that differ between realizations. The implementation envisions support for multiple RV classes, but currently only Normal and LogNormal support variable parameters.
Replace "fixed" with "constant" whenever applicable.
Extract the part where we verity that the probability difference is positive from Normal to the RandomVariable class and apply to all RVs.
Replacing all non-positive `a` values, instead of only replacing 0 values.
We treat an unspecified `theta` as "constant parameters" (across realizations).
Renaming for the sake of clarity - see corresponding comment in PR review.
Replace small arbitrary float with the actual first positive number
The pelicun logo was originally pulled from the gh-pages branch but with the new docs it is no longer available at that location. Instead, we can have it sourced from the master branch which seems much more appropriate
- The lines in the docstring for _handle_operation_list were too long - The keys of the parsed_scaling_specification dict do not need to be initialized
- Streamline part of the new test for capacity scaling
- Initialize the list in the nested dict when the scaling specs are parsed.
- move updates from unreleased to v3.4 in release notes - update version number in init
Also reorders the branches of the if statement to avoid excessive indentation.
ioannis-vm
force-pushed
the
2024-12_update_warning
branch
from
December 6, 2024 11:55
77980e8
to
457bdd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reorders the branches of the if statement to avoid excessive indentation.
Type checking warnings are addressed in #82 .