Fix warning messages triggered by our own code. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated `DMG-` keyword from loss map. - Replace deprecated `BldgRepair` with `Repair`. Both worked for backwards compatibility but triggered a warning. These changes were delayed to verify backwards compatibility. We obviously don't want our own code to trigger warnings.
Add `"deterministic"` and implicitly `None` as valid distribution options for capacity scaling operations.
Change default decision variables to the more common set of {'Cost',
'Time'}. Users who need to include 'Carbon' and 'Energy' should
manually set the decision variables when defining their assessment
objects.
zsarnoczay
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some necessary changes related to PR #51 were held off to verify backwards compatibility. This resulted in a couple of warnings being triggered by our own code, which is of course undesirable. This PR brings in those necessary changes.