Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to submodule for damage and loss library. #48

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

ioannis-vm
Copy link
Contributor

@ioannis-vm ioannis-vm commented Jun 29, 2024

Considering the ongoing transition to the external damage and loss library repository, this commit:

  1. Adds a mapping of prior library file locations to their new location in the repository.
  2. Removes db.py as the contained code is transfered to the external library.

Considering the ongoing transition to the external damage and loss
library repository, this commit adds a mapping of prior library file
locations to their new location in the repository.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (8af9462) to head (d4c08e5).
Report is 36 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   92.52%   92.66%   +0.13%     
==========================================
  Files          12       12              
  Lines        2516     2508       -8     
==========================================
- Hits         2328     2324       -4     
+ Misses        188      184       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ioannis-vm ioannis-vm changed the title Add mapping. Transition to submodule for damage and loss library. Jun 29, 2024
`db.py` was being used as a "safe" existing file. Switching to
`base.py`.
@zsarnoczay
Copy link
Collaborator

Looks good to me, thanks.

@zsarnoczay zsarnoczay merged commit 1b7db9b into NHERI-SimCenter:master Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants