azs - mostly updates related to water network damage simulation and working with custom DL models #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a workflow file to publish the package to PyPI testing whenever a release is made. If succesful, we will change it to publish to the mainline PyPI.
So that it gets uploaded to PyPI instead of TestPyPI.
- Moved `parse_units` and `dict_raise_on_duplicates` from `file_io` to `base` module to avoid cicrular dependency between `base` and `file_io`. - Implemented `convert_units` function in `base` for robust unit conversion across different categories, supporting scalar, list, and np.ndarray types. - Updated `assessment.py` to use `parse_units` from `base` instead of `file_io`. - Added unit tests in `test_base.py` for the new function - Moved unit parsing tests and associated files from `test_file_io.py`, aligning with the refactor. - Cleaned up import statements and unnecessary code in `file_io.py` following the refactor.
… SimCenter simulations while we extend the DLML with the final version of these files
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 93.35% 93.36% +0.01%
==========================================
Files 6 6
Lines 2393 2428 +35
==========================================
+ Hits 2234 2267 +33
- Misses 159 161 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.