updates up to v3.2 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…populate function
…d output directory
…tainty (0.4) rather than total uncertainty (0.65)
CSV remains the default
…mponent vulnerability databases used with a default DB also allow "None" as a damage process to have a simple analysis without any interdependencies between damages
…nly those where damage occurred in at least one realization control this through the options; the default is set to request only the realized damage states
…erence quantities other than 1 ea and constant median consequences (rather than multilinear functions) median consequences for the above model types are properly scaled after this fix
Ignore temporary flycheck files. For what these are, see https://www.flycheck.org/
Adds the ability to scale the median capacity of specified performance groups. Permitted operations include addition, subtraction, multiplication, and division. Use of `eval` was avoided due to security concerns. The median is directly modified at the stage of the capacity RV definition, before sampling, to minimize codebase expansion. Capacity scaling can only be applied to the median (`theta_0`) of `normal` and `lognormal` RVs. Includes a test which may need to be expanded to maximize coverage, particularly for possible exceptions.
I took the liberty to remove this now. -JVM
This commit addresses issues identified with the unit tests and increases the testing coverage.
Removes lines accidentally commited earlier
This commit includes changes made in an attempt to simplify the code in `load_data`. Currently the tests pass but some example use cases fail. Also this implementation appears to be slower than the previous code in certain cases. I am investigating the issues and will resolve them in subsequent commits.
Developers who clone the repo are expected to install the package in development mode using `pip`, as follows: ``` python -m pip install -e . ``` The requirements are already specified in `setup.py`, and it's those requirements that `pip` uses when installing the package. Therefore, there is no need to include them again in the form of a `requirements.txt` file. `requirements_dev.txt` are maintained since they include optional packages used for development purposes and are not needed for the users. Those should be installed after installing `pelicun`, as follows: ``` python -m pip install -r requirements_dev.txt ```
This file is no longer used. Coverage reports are managed through the GitHub workflow (`.github/workflows/tests.yml`).
This commit includes a reqritten version of `load_data`. Similar to the prior version, it avoids transposing the dataframe, as this can be a slow operation when changes are made to it. The commit includes a new approach to inferring the data types of the dataframe's contents. When `Units` are present, this typically forces columns to have an `object` type. When removed, the data types of the columns need to be reassigned. This is done with a new function in `base`, `convert_dtypes`, and unit tests are added. Unit conversions are handled by indiscriminately applying conversion factors to all numeric data. Now it is handled in a vectorized function, eliminating looping over units. For cases where unit conversions are not required, the method separates the unit row/column but does not apply conversion factors. Instead of an empty list, now no conversion is specified by `unit_conversion_factors` being None, which is more intuitive, and is reflected in the updated docstring.
other changes include mistaken variable rename: `adjusted_capacity_RV_reg`
- Removes requirements. - Adds installation instructions for users and developers
Recommend opening issue.
Switch to branch.
Remove unnecessary line
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.