Add calculation of FATES_SAPFLOW to history interface, add sapwood area as history variable #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennykowalcz
changed the title
jennykowalcz
added
the
history output
rgknox
reviewed
Jan 13, 2025
| @@ -3751,6 +3756,13 @@ subroutine update_history_dyn2(this,nc,nsites,sites,bc_in) | |||
| hio_ddbh_si_scpf(io_si,scpf) = hio_ddbh_si_scpf(io_si,scpf) + & | |||
| ccohort%ddbhdt*ccohort%n / m2_per_ha * m_per_cm | |||
|
|
|||
There was a problem hiding this comment.
update_history_dyn2 is a good spot for this diagnostic
Closed
rgknox
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue 1266. It adds a calculation of FATES_SAPFLOW to the history interface code, and adds sapwood area as a history variable so that the user can normalize sapflow by sapwood area to compare to observed values.
(Note, in looking at sapwood area, I discovered, but have not addressed here, that sapwood area is sometimes greater than basal area for shrubs -- discussion 1307.)
Collaborators:
@ckoven @mpaiao @JessicaNeedham @samsrabin helped identify what needed to be done to fix the issue.
Expectation of Answer Changes:
This will change FATES_SAPFLOW, which was previous erroneously zero.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: