draft, RDMA via thallium #69
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swelborn
force-pushed
the
thallium-messenger
branch
from
b700ad4 to
732405d
Compare
swelborn
force-pushed
the
thallium-messenger
branch
from
732405d to
7ad8852
Compare
this is the example given by nanobind. we use it as a starting point for packaging
- use capnproto to serialize and deserialize necessary info for creating numpy array - current implentation of bindings results in some leaked resources after running `pytest tests/`, further investigation needed
- this API is a lot simpler, probably going to remove capnproto eventually. - this example works, but we can avoid copying on recv. future commit.
swelborn
force-pushed
the
thallium-messenger
branch
from
7ad8852 to
153c485
Compare
- this improves python API. - We create an engine, and then pass it into queueclient and queueprovider. - We can then send and receive messages. these messages are numpy arrays. - It is not "complete" but it is a start - Using unique pointers for messages ensures that we are moving data from python into cpp, and vice versa - Set rv policy on data field to take_ownership. Unsure if this is correct
cjh1
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very draft version of RDMA through mochi-thallium