Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine NuGet package tagging #180

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Refine NuGet package tagging #180

merged 1 commit into from
Jan 26, 2025

Conversation

nulltoken
Copy link
Collaborator

@nulltoken nulltoken commented Jan 25, 2025

Pull request description

According to these docs (here and there), tags should be separated by semicolons, not commas (although that seems to work).

Beside aligning the syntax, this also slightly attempts to "optimize" the tagging.

PR meta checklist

  • Pull request is targeted at main branch for code
  • Pull request is linked to all related issues, if any.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

@nulltoken nulltoken requested a review from linkdotnet January 25, 2025 18:34
@nulltoken nulltoken changed the title Enhance NuGet package tagging Refine NuGet package tagging Jan 25, 2025
@nulltoken nulltoken merged commit c9d0eee into main Jan 26, 2025
5 checks passed
@nulltoken nulltoken deleted the ntk/tags branch January 26, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants