Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach startup jobs to optionaly prevent the application start on failure #165

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

nulltoken
Copy link
Collaborator

@nulltoken nulltoken commented Jan 19, 2025

Pull request description

Related:

PR meta checklist

  • Pull request is targeted at main branch for code
  • Pull request is linked to all related issues, if any.

Code PR specific checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@nulltoken nulltoken force-pushed the ntk/startup branch 2 times, most recently from 0491f39 to 4e3359f Compare January 19, 2025 14:18
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/NCronJob/Execution/StartupJobManager.cs 90.90% 1 Missing and 1 partial ⚠️
src/NCronJob/Scheduler/JobWorker.cs 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/NCronJob/Configuration/Builder/JobOption.cs 100.00% <100.00%> (ø)
...NCronJob/Configuration/Builder/JobOptionBuilder.cs 88.88% <100.00%> (ø)
...Job/Configuration/Builder/NCronJobOptionBuilder.cs 88.28% <100.00%> (ø)
src/NCronJob/Execution/JobExecutor.cs 97.00% <100.00%> (ø)
src/NCronJob/Registry/JobDefinition.cs 95.23% <100.00%> (+0.23%) ⬆️
src/NCronJob/Registry/JobRegistry.cs 98.01% <100.00%> (ø)
src/NCronJob/Registry/JobRun.cs 98.63% <100.00%> (-0.02%) ⬇️
src/NCronJob/Registry/JobState.cs 77.77% <100.00%> (+11.11%) ⬆️
src/NCronJob/Scheduler/JobProcessor.cs 100.00% <100.00%> (ø)
src/NCronJob/Scheduler/JobWorker.cs 93.43% <66.66%> (+0.04%) ⬆️
... and 1 more

Copy link
Member

@linkdotnet linkdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - same smaller hints from my side, up to you, whether or not they are important

src/NCronJob/Execution/StartupJobManager.cs Show resolved Hide resolved
src/NCronJob/Execution/StartupJobManager.cs Outdated Show resolved Hide resolved
@nulltoken nulltoken merged commit 9546bc2 into main Jan 19, 2025
4 checks passed
@nulltoken nulltoken deleted the ntk/startup branch January 19, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants