-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread the new year cheer all over IRuntimeRegistry
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
nulltoken
commented
Jan 1, 2025
nulltoken
commented
Jan 1, 2025
That is quite some new years joy ;) |
linkdotnet
approved these changes
Jan 1, 2025
nulltoken
commented
Jan 1, 2025
@linkdotnet Changelog and doco have been updated. Could you please take another look? |
Steven like and appreciate your efforts :D Thank you very much <3 |
linkdotnet
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Context:
In order to not have scheduled jobs interfere with unit test runs, I leverage
IRuntimeRegistry.RemoveJob<T>
in my Xunit Collection fixtures.As I'd rather disable them (in order to later be able to trigger them through the
IInstantJobRegistry
), I started working on makingDisableJob()
acceptIJob
typed parameters.Getting there, it was only making sense to also consider
EnableJob()
.Along the road, I discovered some inconsistencies nearby that I also worked on.
Most relevant proposed changes:
DisableJob()
EnableJob()
RemoveJob()
behave according to its documentationUpdateSchedule()
behavior is consistentPR meta checklist
main
branch for codeCode PR specific checklist