PEAR-2195 - Reverse Tabnabbing (#434)

* PEAR-2195 - add noreferrer to links * PEAR-2195 - remove change to theme
NCIP · Dec 19, 2024 · 961ea88 · 961ea88
1 parent 6750560
commit 961ea88
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/docs/Data_Dictionary/gdcmvs.md b/docs/Data_Dictionary/gdcmvs.md
@@ -57,9 +57,9 @@ hide:
         </label>
       </div>
       <div class="ref-box">
-        <a href="https://ncit.nci.nih.gov/" class="ref-box__link" target="_blank">Search in NCIt</a>
+        <a href="https://ncit.nci.nih.gov/" class="ref-box__link" target="_blank" rel="noreferrer">Search in NCIt</a>
         <a href="https://cadsr.cancer.gov/onedata/Home.jsp"
-          class="ref-box__link" target="_blank">Search in caDSR</a>
+          class="ref-box__link" target="_blank" rel="noreferrer">Search in caDSR</a>
       </div>
     </div>
 </div>

diff --git a/docs/Data_Dictionary/viewer/dictionary-views.js b/docs/Data_Dictionary/viewer/dictionary-views.js
@@ -544,7 +544,7 @@
                 cdeStr =
                   '<a href="' +
                   (data.term_url ? data.term_url : "#") +
-                  '" target="_blank">' +
+                  '" target="_blank" rel="noreferrer">' +
                   data.cde_id +
                   "</a>" +
                   " - " +
@@ -873,7 +873,7 @@
               '</em><span class="dictionary-tooltip-content"><i></i>The links ' +
               "should be included in the files uploaded to the GDC. " +
               "For more information, please refer to the " +
-              '<a href="/Data_Submission_Portal/Users_Guide/Upload_Data/#step1-prepare-files" target="_blank">' +
+              '<a href="/Data_Submission_Portal/Users_Guide/Upload_Data/#step1-prepare-files" target="_blank" rel="noreferrer">' +
               '<!-- b class="fa fa-external-link"></b --> File ' +
               "Preparation's User Guide</a>.</span></span>"
             );

diff --git a/docs/Data_Dictionary/viewer/entity-list-controls.view.html b/docs/Data_Dictionary/viewer/entity-list-controls.view.html
@@ -2,7 +2,7 @@
            <span class="dictionary-tooltip">
                <i class="fa fa-info-circle"></i>&nbsp; <em>Download Template Format</em>: &nbsp;
                <span class="dictionary-tooltip-content">
-                   Use the template to upload data to the GDC. For more information, please refer to <a href="/Data_Submission_Portal/Users_Guide/Upload_Data/" target="_blank">Upload Data's User Guide</a>.
+                   Use the template to upload data to the GDC. For more information, please refer to <a href="/Data_Submission_Portal/Users_Guide/Upload_Data/" target="_blank" rel="noreferrer">Upload Data's User Guide</a>.
                    Click the download icon link <span aria-hidden="true" class="fa fa-cloud-download"></span> to download the respective template(s).</span></span>
         <div class="dropdown">
             <button class="btn md-button dropdown-toggle" data-bs-toggle="dropdown" aria-haspopup="true" id="dictionary-current-template-data-format" aria-expanded="false">

diff --git a/overrides/partials/footer.html b/overrides/partials/footer.html
@@ -2,17 +2,17 @@
     <div class="row">
         <div class="col-md-12 footer-caption">
             <div>
-                <a href="https://portal.gdc.cancer.gov" target="_blank">Site Home</a>
-                | <a href="http://www.cancer.gov/global/web/policies" target="_blank">Policies</a>
-                | <a href="http://www.cancer.gov/global/web/policies/accessibility" target="_blank">Accessibility</a>
-                | <a href="http://www.cancer.gov/global/web/policies/foia" target="_blank">FOIA</a>
-                | <a href="https://www.hhs.gov/vulnerability-disclosure-policy" target="_blank">HHS Vulnerability Disclosure</a>
+                <a href="https://portal.gdc.cancer.gov" target="_blank" rel="noreferrer">Site Home</a>
+                | <a href="http://www.cancer.gov/global/web/policies" target="_blank" rel="noreferrer">Policies</a>
+                | <a href="http://www.cancer.gov/global/web/policies/accessibility" target="_blank" rel="noreferrer">Accessibility</a>
+                | <a href="http://www.cancer.gov/global/web/policies/foia" target="_blank" rel="noreferrer">FOIA</a>
+                | <a href="https://www.hhs.gov/vulnerability-disclosure-policy" target="_blank rel="noreferrer"">HHS Vulnerability Disclosure</a>
             </div>
             <div>
-                <a href="http://www.hhs.gov" target="_blank">U.S. Department of Health and Human Services</a>
-                | <a href="http://www.nih.gov" target="_blank">National Institutes of Health</a>
-                | <a href="http://www.cancer.gov" target="_blank">National Cancer Institute</a>
-                | <a href="http://www.usa.gov" target="_blank">USA.gov</a>
+                <a href="http://www.hhs.gov" target="_blank" rel="noreferrer">U.S. Department of Health and Human Services</a>
+                | <a href="http://www.nih.gov" target="_blank" rel="noreferrer">National Institutes of Health</a>
+                | <a href="http://www.cancer.gov" target="_blank" rel="noreferrer">National Cancer Institute</a>
+                | <a href="http://www.usa.gov" target="_blank" rel="noreferrer">USA.gov</a>
             </div>
             <div>
                 NIH... Turning Discovery Into Health &reg;