Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] VLEN strings #36

Closed
wants to merge 80 commits into from
Closed

[IGNORE] VLEN strings #36

wants to merge 80 commits into from

Conversation

davidhassell
Copy link
Collaborator

@davidhassell davidhassell commented Jan 24, 2025 •
edited
Loading

No description provided.

Bryan Lawrence and others added 30 commits July 10, 2024 11:39
Adding Datatype and check_enum_dtype in a minimal manner - closes #8
3c3f6d6
Basic support for elements of h5netcdf and what it expects to be able…
9994598 
… to import from it's backend (which it expects to be h5py). Also added some better handling for situations where we find datatypes which pyfive doesn't understand.
Test support for graceful enum failure
c12b5b3
Committing to the dtype returned as a numpy dtype, and the extra h5t …
c80ed92 
…interface.
Test for reference_list
04bbef6
(New reference list test still broken) H5D has been disconnected from…
552c463 
… the parent dataobjects so once instantiated it does not need to touch the file metadata.
Interim commit so we have something to point to in a discussion aroun…
e32a1b0 
…d the problem with references and caching everything we need in a variable.
Transition to H5D cached backend is complete, though we still have th…
2d88101 
…e test_reference_list fail
Removed obsolete DatasetDataObjects
2678022
Expose package version in code, and separate testing requirements out…
0078956 
… in package metadata.
Attempt to get b-tree logging in h5d
503cb45
Cleared a few bugs and misunderstandings which arose from workign wit…
ac96f46 
…h h5netcdf (closed #15)
Continue to use open file in h5d, closes #18
b586db0
Test for true bytes-io testing (needed for h5netcdf test compatability)
7f17cc8
Deals with filename issues (closes #19) (and deals with another iobyt…
fd13670 
…es isseue around scalars on contigous storage).
Addressing, I think, upstream issue 53, and includes a test case I sh…
32ad75d 
…ould have included previously
Fix location of files so tests run properly from parent directory.
48b7b9a
Well, I think this is a fix for #23, and it's so complex I'm committi…
2233395 
…ng it now in case my laptop dies and I can't repeat this :-)
Cleaned up issue23 fixes, all tests pass
1e2c424
Test localisation, and a new test for laziness outside a context manager
6da5fda
Changes to support out of context variable access as described in #24
59e8667
Removing the pseudo chunking stuff that snuck into the last commit
34a684a
catching up to the main trunk in h5netcdf
64827c4
Starting to sketch out the pseudo chunking
20693b9
@davidhassell
threadsafe data access
4126e2b
@davidhassell
merge from h5netcdf
8a7e1dc
@valeriupredoi
add deps for mock s3 test
87a1980
@valeriupredoi
add mock s3 test
c7058b6
@davidhassell
posix & s3
df81faf
@davidhassell
tidy
53ff9df
bnlawrence and others added 26 commits January 15, 2025 17:04
@bnlawrence
Merge branch 'h5netcdf' into h5netcdf-fh-2
89ebd2f
@bnlawrence
Merge pull request #27 from NCAS-CMS/h5netcdf-fh-2
fee0759 
Threadsafe data access (Posix and non-Posix)
Tidy up dependencies for testing
13e5e39
Minor changes which come from upstream advice on my two pull requests j…
c4a38b9 
…jhelmus#67 and jjhelmus#66
Suppress reference list warning. It's useless
49aa794
Using context manager for threadsafe test
dba2683
@davidhassell
no returned memory maps
2ba27dc
Test for #16 and #29
e6b518b
More versions of the #29 tests
b1ae323
Better .gitignore
c7e157c
Giving up on in-memory netcdf tests for #29
40c898b
@davidhassell
explicitly close POSIX files
8acf067
vlen strings data test case, vanilla version, and version with missin…
526c642 
…g defined. tests fail.
@davidhassell
add extra posix test for file closure
0e4a45b
@davidhassell
Merge branch 'h5netcdf' into fix-memmap
298edc7
More on h5d and testing. The iter_chunks method is broken and we now …
1fb9c98 
…have a test which shows that.
Support for pyactivestorage via a bespoke `get_chunk_info_from_chunk_…
82dc2a9 
…coord` method
better ignore
838b0a5
The first vlen data test passes with this code
a633683
closer to a solution for #29. These tests pass, but we need to deal w…
fbdda40 
…ith multidimensional arrays as well.
Partially working vlen string support, issues with global heap usage …
a20763f 
…and dtypes remain
Passing all vlen tests for #29, though we are ignoreing the dtype of …
e7c465e 
…the dataset itself, which needs to be a new issue. Also the caching stuff needs to be a new issue.
@bnlawrence
Merge pull request #33 from NCAS-CMS/vlen
580e3df 
All the pathological tests now pass though two new lower priority issues have been generated.
Merge remote-tracking branch 'refs/remotes/origin/h5netcdf' into h5ne…
0a4c801 
…tcdf
Merge branch 'fix-memmap' into h5netcdf
b955b4b
Remaining tests for vlen and iterchunks, support for vlen dtypes (closes
e40c7d7 
 #34)
@davidhassell
Copy link
Collaborator Author

Opened in error.

@davidhassell davidhassell changed the title VLEN strings [IGNORE] VLEN strings Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnlawrence bnlawrence Awaiting requested review from bnlawrence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidhassell @valeriupredoi @bnlawrence